From: Paul Gortmaker <p_gortmaker@yahoo.com>
To: Andrzej Krzysztofowicz <ankry@green.mif.pg.gda.pl>
Cc: kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net #3
Date: Wed, 30 May 2001 01:49:47 -0400 [thread overview]
Message-ID: <3B14A61B.3DF7C1D7@yahoo.com> (raw)
In-Reply-To: <200105300041.CAA04507@green.mif.pg.gda.pl>
Andrzej Krzysztofowicz wrote:
>
> The following patch fixes some ISA PnP #ifdefs (enable modular,
> disable when non-available) for 3c509 and smc-ultra.
> -#ifdef CONFIG_ISAPNP
> +#if defined(CONFIG_ISAPNP) || (defined(CONFIG_ISAPNP_MODULE) && defined(MODULE))
Hrrm. AFAICT the token CONFIG_ISAPNP_MODULE will never be defined. :-)
Regardless, we can just toss the #ifdefs altogether. They aren't strictly
required as appropriate stubs exist in linux/isapnp.h and that is what
they are there for. (I'd recommend this for 2.5, not 2.4 though.)
Granted, the CONFIG_ISAPNP buys you a slight reduction in driver
size (even over the stubs) which somewhat seemed worthwhile in the
past. But most of it is __init anyway, and for 2.5 I'd argue that the
readability and lack of ifdefs outweighs the slight size change.
Paul.
next prev parent reply other threads:[~2001-05-30 9:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-05-30 0:41 [PATCH] net #3 Andrzej Krzysztofowicz
2001-05-30 5:49 ` Paul Gortmaker [this message]
2001-05-30 10:53 ` Andrzej Krzysztofowicz
2001-05-30 12:03 ` Keith Owens
2001-05-30 9:11 ` David Woodhouse
2001-05-30 10:11 ` Andrzej Krzysztofowicz
2001-05-30 10:39 ` Jeff Garzik
2001-05-30 11:02 ` Andrzej Krzysztofowicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3B14A61B.3DF7C1D7@yahoo.com \
--to=p_gortmaker@yahoo.com \
--cc=ankry@green.mif.pg.gda.pl \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox