From: Studierende der Universitaet des Saarlandes <masp0008@stud.uni-sb.de>
To: alan@lxorguk.ukuu.org.uk
Cc: linux-kernel@vger.kernel.org, ankry@green.mif.pg.gda.pl
Subject: Re: [PATCH] net
Date: Wed, 30 May 2001 10:36:21 +0000 [thread overview]
Message-ID: <3B14CD25.FFF8019E@stud.uni-saarland.de> (raw)
> > @@ -643,9 +631,7 @@
> > eexp_hw_tx_pio(dev,data,length);
> > }
> > dev_kfree_skb(buf);
> > -#ifdef CONFIG_SMP
> > spin_unlock_irqrestore(&lp->lock, flags);
> > -#endif
> > enable_irq(dev->irq);
> > return 0;
>
> They are done this way to get good non SMP performance. Your changes would
> ruin that.
I think the spin_lock could be removed on SMP, too.
Concurrent xmit & timeout calls are prevented by core network code, and
concurrent interrupts are prevented by disable_irq().
Or replace spin_lock_irqsave() with spin_lock().
--
Manfred
reply other threads:[~2001-05-30 10:37 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3B14CD25.FFF8019E@stud.uni-saarland.de \
--to=masp0008@stud.uni-sb.de \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=ankry@green.mif.pg.gda.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=manfred@colorfullife.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox