* Re: [PATCH] net
@ 2001-05-30 10:36 Studierende der Universitaet des Saarlandes
0 siblings, 0 replies; only message in thread
From: Studierende der Universitaet des Saarlandes @ 2001-05-30 10:36 UTC (permalink / raw)
To: alan; +Cc: linux-kernel, ankry
> > @@ -643,9 +631,7 @@
> > eexp_hw_tx_pio(dev,data,length);
> > }
> > dev_kfree_skb(buf);
> > -#ifdef CONFIG_SMP
> > spin_unlock_irqrestore(&lp->lock, flags);
> > -#endif
> > enable_irq(dev->irq);
> > return 0;
>
> They are done this way to get good non SMP performance. Your changes would
> ruin that.
I think the spin_lock could be removed on SMP, too.
Concurrent xmit & timeout calls are prevented by core network code, and
concurrent interrupts are prevented by disable_irq().
Or replace spin_lock_irqsave() with spin_lock().
--
Manfred
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2001-05-30 10:37 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2001-05-30 10:36 [PATCH] net Studierende der Universitaet des Saarlandes
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox