Re: [PATCH] net #3

[Jeff Garzik <jgarzik@mandrakesoft.com>]

David Woodhouse wrote:
> 
> ankry@green.mif.pg.gda.pl said:
> > -#ifdef CONFIG_ISAPNP
> > +#if defined(CONFIG_ISAPNP) || (defined(CONFIG_ISAPNP_MODULE) && defined(MODULE))
> 
> The result here would be a 3c509 module which differs depending on whether
> the ISAPNP module happened to be compiled at the same time or not.

In and of itself, that is an acceptable result.  We simply cannot take
into kernel configuration variations between two kernel builds.  If you
build your isapnp module with one configuration, and your 3c509 module
with another config, consider yourself lucky that it works at all.


> The ISAPNP-specific parts of the code aren't large. Please consider
> including them unconditionally instead.

I probably agree with you and Paul, but I'll have to give it a bit more
thought.  Past a certain point, bus support needs to be in its own
driver, similar to drivers/sound/{sb_card,sb_common}.c.  But in this
particular case, that would be overkill.

-- 
Jeff Garzik      | Disbelief, that's why you fail.
Building 1024    |
MandrakeSoft     |