Re: [PATCH] support for Cobalt Networks (x86 only) systems (for real this time)

Jeff Garzik
2001-06-01T07:27:35Z

> > Off-hand I see old style initialization. Is it right for new driver?
>
> the old-style init is because it is an old driver. I want to do a full-on
> rework, but haven't had the time.

New-style init by itself shouldn't be hard to do, independent of a full
re-work...

> > 2. Spaces and tabs are mixed in funny ways, makes to cute effects
> > when quoting diffs.
>
> I've tried to eliminate that when I see it - I'll give the diff a close
> examination.

Why not just run indent over the source before submitting. That will
regularize this stuff, and ensure that you are close to
Documentation/CodingStyle.

Here is the command I use. The first two options are the only really
importants ones...

indent -kr -i8 -npsl -pcs -l100 -lc120

(line length is 100 because line length 72/75/80 winds up wrapping long
printk and logic lines when typically the programmer didn't want them to
be wrapped)

--
Jeff Garzik | Disbelief, that's why you fail.
Building 1024 |
MandrakeSoft |