[PATCH] to init/main.c

[PATCH] to init/main.c

[Daniel Dickman]

Here is a small patch to main.c.

It does the following:
- makes sure that asm/mtrr.h actually gets included, and
- changes formatting in one place as per Documentation/CodingStyle

--- linux-2.4.5/init/main.c     Tue May 22 12:35:42 2001
+++ linux/init/main.c   Sat Jun 16 11:48:42 2001
@@ -50,7 +50,7 @@
 #endif
 
 #ifdef CONFIG_MTRR
-#  include <asm/mtrr.h>
+#include <asm/mtrr.h>
 #endif
 
 #ifdef CONFIG_NUBUS
@@ -292,8 +292,7 @@
        ROOT_DEV = name_to_kdev_t(line);
        memset (root_device_name, 0, sizeof root_device_name);
        if (strncmp (line, "/dev/", 5) == 0) line += 5;
-       for (i = 0; i < sizeof root_device_name - 1; ++i)
-       {
+       for (i = 0; i < sizeof root_device_name - 1; ++i) {
            ch = line[i];
            if ( isspace (ch) || (ch == ',') || (ch == '\0') ) break;
            root_device_name[i] = ch;

Re: [PATCH] to init/main.c

[Jeff Garzik]

Daniel Dickman wrote:
> Here is a small patch to main.c.
> 
> It does the following:
> - makes sure that asm/mtrr.h actually gets included, and

> --- linux-2.4.5/init/main.c     Tue May 22 12:35:42 2001
> +++ linux/init/main.c   Sat Jun 16 11:48:42 2001
> @@ -50,7 +50,7 @@
>  #endif
> 
>  #ifdef CONFIG_MTRR
> -#  include <asm/mtrr.h>
> +#include <asm/mtrr.h>
>  #endif

huh?

There is absolutely nothing wrong with that include line.

-- 
Jeff Garzik      | Andre the Giant has a posse.
Building 1024    |
MandrakeSoft     |

Re: [PATCH] to init/main.c

[Richard Gooch]

Daniel Dickman writes:
> Here is a small patch to main.c.
> 
> It does the following:
> - makes sure that asm/mtrr.h actually gets included, and

What the hell is this? It is already included!

> - changes formatting in one place as per Documentation/CodingStyle
> 
> --- linux-2.4.5/init/main.c     Tue May 22 12:35:42 2001
> +++ linux/init/main.c   Sat Jun 16 11:48:42 2001
> @@ -50,7 +50,7 @@
>  #endif
>  
>  #ifdef CONFIG_MTRR
> -#  include <asm/mtrr.h>
> +#include <asm/mtrr.h>
>  #endif
>  
>  #ifdef CONFIG_NUBUS

I don't want this change. It's not fixing anything and removes the
intentional indentation.

And was there a reason not to Cc: me?

				Regards,

					Richard....
Permanent: rgooch@atnf.csiro.au
Current:   rgooch@ras.ucalgary.ca