public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Guy Van Den Bergh <guy.vandenbergh@pandora.be>
To: Ben Greear <greearb@candelatech.com>
Cc: linux-kernel@vger.kernel.org, Holger Kiehl <Holger.Kiehl@dwd.de>,
	"David S. Miller" <davem@redhat.com>,
	VLAN Mailing List <vlan@Scry.WANfear.com>,
	"vlan-devel (other)" <vlan-devel@lists.sourceforge.net>,
	Lennert <buytenh@gnu.org>, Gleb Natapov <gleb@nbase.co.il>
Subject: Re: [Vlan-devel] Should VLANs be devices or something else?
Date: Fri, 22 Jun 2001 00:10:12 +0200	[thread overview]
Message-ID: <3B3270C4.3080103@pandora.be> (raw)
In-Reply-To: <Pine.LNX.4.30.0106191016200.27487-100000@talentix.dwd.de> <3B2FCE0C.67715139@candelatech.com>


Maybe this has been discussed already, but what about integration
with the bridging code? Is it possible to add add a vlan interface to a 
bridge? In other words, can you bridge between one or more regular 
interfaces and a vlan?

Regards,
Guy

Ben Greear wrote:

> I have had a good discussion with Dave Miller today, and there
> is one outstanding issue to clear up before my 802.1Q VLAN patch may
> be considered for acceptance into the kernel:
> 
> Should VLANs be devices or some other thing?
> 
> I strongly feel that they should be devices for many reasons.
> 
> 1)  It makes integration with user-space tools (ip, ifconfig, arp...) a non-issue.
> 
> 2)  It is logically correct, a VLAN is a (net_)device and in all ways acts like one.
> 
> 3)  It introduces no fast-path performance degradation that I know of.  The one
>     slow path involves the linear lookup of a device by name (or id??).  This can
>     be fixed by hashing the list, if needed.
> 
> 4)  Both VLAN patches have used VLANs-as-devices from the beginning, and have
>     seen no ill affects to this approach that would be mitigated by some other
>     architecture.
> 
> However, we need the community as a whole to agree more-or-less that my
> (and others who share them) arguments are sound.  So please, bring your
> complaints fowards now...or forever patch by hand!
> 
> Also, any other complaints or suggestions for the VLAN code should be
> mentioned too, of course!
> 
> If you wish to view the patch, get the 1.0.1 release from my vlan page:
> http://scry.wanfear.com/~greear/vlan.html
> I will release a new one shortly with the fast-dev-lookup code
> (which is already #ifdef'd out) completely removed, as per Dave's
> wish.
> 
> Thanks,
> Ben
> 
> 



  parent reply	other threads:[~2001-06-21 22:14 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-06-19  8:19 VLAN in kernel? Holger Kiehl
2001-06-19 22:11 ` Should VLANs be devices or something else? Ben Greear
2001-06-19 22:45   ` Dax Kelson
2001-06-19 22:49     ` David S. Miller
2001-06-19 22:52       ` Dax Kelson
2001-06-19 23:16       ` Ben Greear
2001-06-20  0:31         ` Marcell Gal
2001-06-20  1:24           ` [VLAN] " Ben Greear
2001-06-20  8:10         ` Eran Man
2001-06-20  9:32       ` Gleb Natapov
2001-06-20  7:21   ` [VLAN] " Sander Steffann
2001-06-22  6:12     ` Peter C. Norton
2001-06-22  6:27       ` Albert D. Cahalan
2001-06-22  6:36         ` Ben Greear
2001-06-21 22:10   ` Guy Van Den Bergh [this message]
2001-06-21 22:54     ` [Vlan-devel] " Ben Greear
2001-06-22 15:00       ` Matthias Welwarsky
2001-06-22 15:46         ` Chris Wedgwood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3B3270C4.3080103@pandora.be \
    --to=guy.vandenbergh@pandora.be \
    --cc=Holger.Kiehl@dwd.de \
    --cc=buytenh@gnu.org \
    --cc=davem@redhat.com \
    --cc=gleb@nbase.co.il \
    --cc=greearb@candelatech.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vlan-devel@lists.sourceforge.net \
    --cc=vlan@Scry.WANfear.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox