From: Jeff Garzik <jgarzik@mandrakesoft.com>
To: "Jhon H. Caicedo O." <jhcaiced@osso.org.co>
Cc: linux-kernel@vger.kernel.org, Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: AMD756 PCI IRQ Routing Patch 0.2.0
Date: Fri, 22 Jun 2001 14:28:30 -0400 [thread overview]
Message-ID: <3B338E4E.D1FDD74D@mandrakesoft.com> (raw)
In-Reply-To: <3B3343E6.122965AC@osso.org.co>
"Jhon H. Caicedo O." wrote:
> This is an updated version of the patch for AMD756 PCI IRQ Routing,
> the changes are to use the read/write_config_nybble functions,
> this makes the code shorter.
Looks much better, thanks!
> + printk(KERN_INFO "AMD756: dev %04x:%04x, router pirq : %d get irq : %2d\n",
> + dev->vendor, dev->device, pirq, irq);
[...]
> + printk(KERN_INFO "AMD756: dev %04x:%04x, router pirq : %d SET irq : %2d\n",
> + dev->vendor, dev->device, pirq, irq);
None of the other PCI IRQ routines print out IRQ routing messages, so
these shouldn't either. I assume this is debugging code?
Further, the printks are potentially misleading, because pirq_amd756_get
might not receive a valid irq, if 'pirq' is greater than 4.
Jeff
--
Jeff Garzik | Andre the Giant has a posse.
Building 1024 |
MandrakeSoft |
next prev parent reply other threads:[~2001-06-22 18:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-06-22 13:11 AMD756 PCI IRQ Routing Patch 0.2.0 Jhon H. Caicedo O.
2001-06-22 18:28 ` Jeff Garzik [this message]
2001-06-22 18:39 ` Jhon H. Caicedo O.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3B338E4E.D1FDD74D@mandrakesoft.com \
--to=jgarzik@mandrakesoft.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jhcaiced@osso.org.co \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox