osst & ide-2.2.19 conflict?

osst & ide-2.2.19 conflict?

[Anil B. Somayaji]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

In the ide.2.2.19.05042001 patch, there is the following bit of code
in ide-scsi.c, which prevents the ide-scsi driver from allowing access
to an OnStream DI-30 tape drive.  This is strange, since this same
drive can be used with the included ide-scsi + osst drivers in the
stock 2.2.19 kernel.  If you delete this bit, however, ide-scsi
recognizes the drive, and the osst driver seems to work fine.

Here's the offending code:

  #ifndef CONFIG_BLK_DEV_IDETAPE
   /*
    * The Onstream DI-30 does not handle clean emulation, yet.
    */
   if (strstr(drive->id->model, "OnStream DI-30")) {
           printk("ide-tape: ide-scsi emulation is not supported for %s.\n", drive->id->model);
           continue;
   }
  #endif /* CONFIG_BLK_DEV_IDETAPE */

Any reason for this to stay in the ide patch, or is it now obsolete?

  --Anil

- -- 
Anil Somayaji (soma@cs.unm.edu)
http://www.cs.unm.edu/~soma
+1 505 872 3150
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)

iEYEARECAAYFAjs0Q/UACgkQXOpXEmNZ3SfrogCfbNzSB7zOjkItzYTOoplxaJJt
5AYAnRrB+KGTYj7wf3/GeV92TLvpKGqi
=1TVG
-----END PGP SIGNATURE-----

Re: osst & ide-2.2.19 conflict?

[Willem Riede]

"Anil B. Somayaji" wrote:
> 
> In the ide.2.2.19.05042001 patch, there is the following bit of code
> in ide-scsi.c, which prevents the ide-scsi driver from allowing access
> to an OnStream DI-30 tape drive.  This is strange, since this same
> drive can be used with the included ide-scsi + osst drivers in the
> stock 2.2.19 kernel.  If you delete this bit, however, ide-scsi
> recognizes the drive, and the osst driver seems to work fine.
> 
> Here's the offending code:
> 
>   #ifndef CONFIG_BLK_DEV_IDETAPE
>    /*
>     * The Onstream DI-30 does not handle clean emulation, yet.
>     */
>    if (strstr(drive->id->model, "OnStream DI-30")) {
>            printk("ide-tape: ide-scsi emulation is not supported for %s.\n", drive->id->model);
>            continue;
>    }
>   #endif /* CONFIG_BLK_DEV_IDETAPE */
> 
> Any reason for this to stay in the ide patch, or is it now obsolete?
> 
It is obsolete, and can safely be removed.

Success. Willem Riede.