From: Jeff Garzik <jgarzik@mandrakesoft.com>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: Linus Torvalds <torvalds@transmeta.com>,
"Grover, Andrew" <andrew.grover@intel.com>
Subject: ACPI fundamental locking problems
Date: Tue, 03 Jul 2001 13:55:43 -0400 [thread overview]
Message-ID: <3B42071F.BD5C8A21@mandrakesoft.com> (raw)
I used to be pretty excited about ACPI, until today.
I was reading through the ACPI spec, to see what was required to obtain
the IRQ routing table from AML. Continued reading... until I hit a
section talking about the ACPI global lock.
events/evxface.c:610:acpi_acquire_global_lock ->
events/evmisc.c:337:acpi_ev_acquire_global_lock ->
include/platform/acgcc.h:52:ACPI_ACQUIRE_GLOBAL_LOCK
My immediate objections are,
(a) acgcc.h is re-implementing spinlocks in a non-standard,
non-portable, and expensive way, and (b) this entire code path is
incredibly expensive.
But my fundamental objection is,
we are depending on vendors to get locking right in their ACPI tables.
And assume by some magic or design that said locking works with whatever
unrelated kernel locking is going on.
It is my initial belief that a smaller info query interface that can
parse useful ACPI would be more effective. For times like
suspend/resume where we would want to execute control methods, well,
there's always the disasm -> write-small-driver cycle. Who knows if
this is a realistics proposed solution. But it really scares me to
depend on vendors to get locking right.
We'll see what 2.5 will bring...
</soapbox>
--
Jeff Garzik | "I respect faith, but doubt is
Building 1024 | what gives you an education."
MandrakeSoft | -- Wilson Mizner
next reply other threads:[~2001-07-03 17:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-07-03 17:55 Jeff Garzik [this message]
2001-07-03 19:10 ` ACPI fundamental locking problems Johannes Erdfelt
-- strict thread matches above, loose matches on Subject: below --
2001-07-03 18:54 Grover, Andrew
2001-07-03 19:08 ` Alan Cox
2001-07-03 19:20 ` Jeff Garzik
2001-07-03 19:39 ` Alan Cox
2001-07-09 22:44 ` Pavel Machek
2001-07-12 21:27 ` Alan Cox
2001-07-09 22:44 ` Pavel Machek
2001-07-03 19:37 ` Dave Jones
2001-07-03 19:37 ` Jeff Garzik
2001-07-03 21:28 Grover, Andrew
2001-07-03 21:37 ` Alan Cox
2001-07-03 21:53 ` arjan
2001-07-03 22:01 Grover, Andrew
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3B42071F.BD5C8A21@mandrakesoft.com \
--to=jgarzik@mandrakesoft.com \
--cc=andrew.grover@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox