Re: VM in 2.4.7-pre hurts...

Marcelo Tosatti
2001-07-11T02:38:00Z

On Mon, 9 Jul 2001, Mike Galbraith wrote:

> On 9 Jul 2001, Christoph Rohland wrote:
>
> > Hi Mike,
> >
> > On Mon, 9 Jul 2001, Mike Galbraith wrote:
> > > --- mm/shmem.c.org Mon Jul 9 09:03:27 2001
> > > +++ mm/shmem.c Mon Jul 9 09:03:46 2001
> > > @@ -264,8 +264,8 @@
> > > info->swapped++;
> > >
> > > spin_unlock(&info->lock);
> > > -out:
> > > set_page_dirty(page);
> > > +out:
> > > UnlockPage(page);
> > > return error;
> > > }
> > >
> > > So, did I fix it or just bust it in a convenient manner ;-)
> >
> > ... now you drop random pages. This of course helps reducing memory
> > pressure ;-)
>
> (shoot. I figured that was too easy to be right)
>
> > But still this may be a hint. You are not running out of swap, aren't
> > you?
>
> I'm running oom whether I have swap enabled or not. The inactive
> dirty list starts growing forever, until it's full of (aparantly)
> dirty pages and I'm utterly oom.

We can make sure if this (inactive full of dirty pages) is really the case
with the tracing code.

The shmem fix in 2.4.7-pre5 is the solution for your problem ?

If not, I'll port the tracing code to the pre5 and hopefully we can
actually figure out what is going on here.