From: Tim Hockin <thockin@sun.com>
To: mj@ucw.cz
Cc: alan@redhat.com,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [PATCH] PCI probing status cleanup
Date: Mon, 09 Jul 2001 23:56:05 -0700 [thread overview]
Message-ID: <3B4AA705.29150671@sun.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 316 bytes --]
Martin et al,
Attached is a tiny patch that clears the master abort bit on bridges when
probing PCI devices.
Please let me know if there is any reason this would not be included in the
mainline kernel.
Thanks
Tim
--
Tim Hockin
Systems Software Engineer
Sun Microsystems, Cobalt Server Appliances
thockin@sun.com
[-- Attachment #2: pci_bridge.diff --]
[-- Type: text/plain, Size: 867 bytes --]
diff -ruN dist-2.4.6/drivers/pci/pci.c cobalt-2.4.6/drivers/pci/pci.c
--- dist-2.4.6/drivers/pci/pci.c Mon Jul 2 14:42:53 2001
+++ cobalt-2.4.6/drivers/pci/pci.c Mon Jul 9 11:04:01 2001
@@ -1229,8 +1233,19 @@
return NULL;
/* some broken boards return 0 or ~0 if a slot is empty: */
- if (l == 0xffffffff || l == 0x00000000 || l == 0x0000ffff || l == 0xffff0000)
+ if (l == 0xffffffff || l == 0x00000000
+ || l == 0x0000ffff || l == 0xffff0000) {
+ /*
+ * host/pci and pci/pci bridges will set Received Master Abort
+ * (bit 13) on failed configuration access (happens when
+ * searching for devices). To be safe, clear the status
+ * register.
+ */
+ unsigned short st;
+ pci_read_config_word(temp, PCI_STATUS, &st);
+ pci_write_config_word(temp, PCI_STATUS, st);
return NULL;
+ }
dev = kmalloc(sizeof(*dev), GFP_KERNEL);
if (!dev)
next reply other threads:[~2001-07-10 6:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-07-10 6:56 Tim Hockin [this message]
2001-07-10 12:37 ` [PATCH] PCI probing status cleanup Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3B4AA705.29150671@sun.com \
--to=thockin@sun.com \
--cc=alan@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mj@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox