Re: [PATCH] sym53c8xx timer rework

Tim Hockin
2001-07-10T18:14:56Z

Studierende der Universitaet des Saarlandes wrote:

> > + NCR_LOCK_NCB(np, flags);
> > + del_timer(&np->timer);
> > + NCR_UNLOCK_NCB(np, flags);
>
> I'm only reading the diff, but this change looks wrong.
> The simplest solution is del_timer_sync() instead of
> LOCK;del_timer;UNLOCK.

I didn't even realize there was a del_timer_sync(). That does what is
needed. 3 lines become 1, I guess.

Thanks, CC:ed to Gerard and crew.

--
Tim Hockin
Systems Software Engineer
Sun Microsystems, Cobalt Server Appliances
thockin@sun.com