Re: [PATCH] PCI probing status cleanup

[Jeff Garzik <jgarzik@mandrakesoft.com>]

Tim Hockin wrote:
>         /* some broken boards return 0 or ~0 if a slot is empty: */
> -       if (l == 0xffffffff || l == 0x00000000 || l == 0x0000ffff || l == 0xffff0000)
> +       if (l == 0xffffffff || l == 0x00000000
> +        || l == 0x0000ffff || l == 0xffff0000) {
> +               /*
> +                * host/pci and pci/pci bridges will set Received Master Abort
> +                * (bit 13) on failed configuration access (happens when
> +                * searching for devices).  To be safe, clear the status
> +                * register.
> +                */
> +               unsigned short st;
> +               pci_read_config_word(temp, PCI_STATUS, &st);
> +               pci_write_config_word(temp, PCI_STATUS, st);
>                 return NULL;
> +       }

ok, though I wonder if we shouldn't just clear status for all PCI
devices on boot for paranoia's sake.

-- 
Jeff Garzik      | A recent study has shown that too much soup
Building 1024    | can cause malaise in laboratory mice.
MandrakeSoft     |