From: "Randy.Dunlap" <rddunlap@osdlab.org>
To: nils@kernelconcepts.de, Alan <alan@lxorguk.ukuu.org.uk>,
Linus <torvalds@transmeta.com>,
linux-kernel@vger.kernel.org
Subject: [patch-v2] i810 TCO Oops
Date: Wed, 11 Jul 2001 14:43:40 -0700 [thread overview]
Message-ID: <3B4CC88C.572DEDA5@osdlab.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 216 bytes --]
Um, having lunch has created a better patch IMO.
It removes the "if (assignment_and_test)" line
and still fixes the Oops.
Please apply this one instead if possible...
to 2.4.7-preX and 2.3.6-acN.
Thanks.
--
~Randy
[-- Attachment #2: i810-foundv2.diff --]
[-- Type: text/plain, Size: 494 bytes --]
--- linux/drivers/char/i810-tco.c.org Mon Jul 2 13:56:41 2001
+++ linux/drivers/char/i810-tco.c Wed Jul 11 14:25:21 2001
@@ -261,11 +261,13 @@
*/
pci_for_each_dev(dev) {
- if (pci_match_device(i810tco_pci_tbl, dev))
+ if (pci_match_device(i810tco_pci_tbl, dev)) {
+ i810tco_pci = dev;
break;
+ }
}
- if ((i810tco_pci = dev)) {
+ if (i810tco_pci) {
/*
* Find the ACPI base I/O address which is the base
* for the TCO registers (TCOBASE=ACPIBASE + 0x60)
reply other threads:[~2001-07-11 21:44 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3B4CC88C.572DEDA5@osdlab.org \
--to=rddunlap@osdlab.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=nils@kernelconcepts.de \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox