public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Bruce Korb <bkorb@pacbell.net>
To: GCC-Bugs <gcc-bugs@gcc.gnu.org>, Raul Nunez <dervishd@jazzfree.com>
Cc: bkorb@pacbell.net, linux-kernel@vger.kernel.org
Subject: Re: Strange fixinclude behavior for GCC 3.0
Date: Fri, 20 Jul 2001 18:08:37 -0700	[thread overview]
Message-ID: <3B58D615.11E727EF@pacbell.net> (raw)
In-Reply-To: <3B5731FC.76653135@veritas.com>


>     Hello everybody at GCC :)

Hello,

> 2.- Fixincludes fixes [several] includes from the linux kernel [...]

I ran fixincl against today's 2.4.7:

> ....
> Applying machine_name             to linux/a.out.h
> Fixed:  linux/a.out.h
> ....
> Applying avoid_wchar_t_type       to linux/nls.h
> Fixed:  linux/nls.h
> ....
> Applying io_quotes_def            to linux/i2c.h
> Fixed:  linux/i2c.h
> ....
> Applying io_quotes_use            to net/irda/irtty.h
> Fixed:  net/irda/irtty.h
> Applying io_quotes_use            to net/irda/irmod.h
> Fixed:  net/irda/irmod.h
> Applying machine_name             to net/dsfield.h
> Fixed:  net/dsfield.h
> ....
> Cleaning up unneeded directories:

It looks like six headers got fixed.  "linux/a.out.h" and "linux/nls.h"
were properly fixed, "net/dsfield.h" is an unavoidable dumb fix,
and there are *three* files that were unchanged and appear in
the fixed directory:  linux/i2c.h net/irda/irtty.h net/irda/irmod.h
All three were "fixed" by io_quotes_def or _use.  Since there
is supposed to be code that does a byte-by-byte comparison of
the results before the output file gets created, it is curious
indeed.  Something is tripping something up.  Thanks for your report!

 - Bruce

$ for f in `find * -type f` ; do diff -u $SDIR/$f $f ; done
--- /work/kernel/linux-2.4.7/include/linux/a.out.h
+++ linux/a.out.h       Fri Jul 20 17:44:23 2001
@@ -127,7 +136,7 @@
 #define SEGMENT_SIZE PAGE_SIZE
 #endif

-#ifdef linux
+#ifdef __linux__
 #include <asm/page.h>
 #if defined(__i386__) || defined(__mc68000__)
 #define SEGMENT_SIZE   1024
--- /work/kernel/linux-2.4.7/include/linux/nls.h
+++ linux/nls.h Fri Jul 20 17:44:23 2001
@@ -1,10 +1,21 @@
 #ifndef _LINUX_NLS_H
 #define _LINUX_NLS_H

 #include <linux/init.h>

 /* unicode character */
+#ifndef __cplusplus
 typedef __u16 wchar_t;
+#endif
 
 struct nls_table {
        char *charset;
--- /work/kernel/linux-2.4.7/include/linux/i2c.h
+++ linux/i2c.h Fri Jul 20 17:44:26 2001
<<NO CHANGES>>

--- /work/kernel/linux-2.4.7/include/net/irda/irtty.h
+++ net/irda/irtty.h    Fri Jul 20 17:44:29 2001
<<NO CHANGES>>

--- /work/kernel/linux-2.4.7/include/net/irda/irmod.h
+++ net/irda/irmod.h    Fri Jul 20 17:44:29 2001
<<NO CHANGES>>

--- /work/kernel/linux-2.4.7/include/net/dsfield.h
+++ net/dsfield.h       Fri Jul 20 17:44:29 2001
@@ -51,7 +60,7 @@
 }
 
 
-#if 0 /* put this later into asm-i386 or such ... */
+#if 0 /* put this later into asm-__i386__ or such ... */
 
 static inline void ip_change_dsfield(struct iphdr *iph,__u16 dsfield)
 {

           reply	other threads:[~2001-07-21  1:06 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <3B5731FC.76653135@veritas.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3B58D615.11E727EF@pacbell.net \
    --to=bkorb@pacbell.net \
    --cc=dervishd@jazzfree.com \
    --cc=gcc-bugs@gcc.gnu.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox