Re: REPOST by request: String literal patch (was Re: 2.4.7 -- GCC-3.0 -- "multiline string literals deprecated" -- PATCH)

[paulr <reichp@ameritech.net>]

Pete Zaitcev wrote:
> 
> > Date: Tue, 31 Jul 2001 23:32:21 -0500
> > From: paulr <reichp@ameritech.net>
> > To: Pete Zaitcev <zaitcev@redhat.com>
> > CC: linux-kernel@vger.kernel.org

---------------------<etc>---------------------
> > --- linux/arch/i386/kernel/semaphore.c.orig   Sat Jul 28 13:57:29 2001
> > +++ linux/arch/i386/kernel/semaphore.c        Sat Jul 28 14:50:50 2001
> > @@ -181,56 +181,56 @@
> >  ".text\n"
> >  ".align 4\n"
> >  ".globl __down_failed\n"
> > -"__down_failed:\n\t"
> > -     "pushl %eax\n\t"
> > +"__down_failed:\n"
> > +"    pushl %eax\n"
> > +"    pushl %edx\n"
> 
> Why did you replace this? It was not a multi-line literal.
> It it triggered a warning, I'd suspect the gcc.
> 
> -- Pete

Pete,

There was no operational or gcc-3.0 compiler 
issue with the above stanza.

I altered this section only only to indent and 
align the text.  My choice was Purely Esthetic(TM).

It worked fine either way, 'specially on a GHz
althlon   ;-)

Regards,

Paul


-- 
*********************************************
Paul Reich              RF/Microwave Engineer

    Support the "Freedom To Innovate"...
                Just say "No".

*********************************************