From: Andrew Morton <akpm@zip.com.au>
To: Hugh Dickins <hugh@veritas.com>
Cc: Kai Germaschewski <kai@tp1.ruhr-uni-bochum.de>,
Linus Torvalds <torvalds@transmeta.com>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] show_trace() module_end = 0?
Date: Fri, 03 Aug 2001 12:52:41 +1000 [thread overview]
Message-ID: <3B6A11F9.9C5FCDE7@zip.com.au> (raw)
In-Reply-To: Pine.LNX.4.21.0108021822340.959-100000@localhost.localdomain
Hugh Dickins wrote:
>
> > The other, minor problem is that we should walk the module_list under
> > lock_kernel() only, but I wasn't brave enough to add this to the
> > show_trace() code path.
>
> I think it's just modlist_lock you'd need. Not sure whether better
> to try for it or ignore it. CC'ed Andrew "spinlock-buster" Morton
> for his opinion.
Debugging things like show_trace() may be called from any context
at all, and hence really cannot take locks. We just live with the
race possibilities.
One could possibly play games with spin_trylock, but I don't expect
it'd help much - if you failed to get the lock what can you do?
-
next prev parent reply other threads:[~2001-08-03 2:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-08-02 14:06 [PATCH] show_trace() module_end = 0? Kai Germaschewski
2001-08-02 17:58 ` Hugh Dickins
2001-08-03 2:52 ` Andrew Morton [this message]
-- strict thread matches above, loose matches on Subject: below --
2001-07-12 15:42 Hugh Dickins
2001-07-12 16:03 ` Linus Torvalds
2001-07-12 17:29 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3B6A11F9.9C5FCDE7@zip.com.au \
--to=akpm@zip.com.au \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=hugh@veritas.com \
--cc=kai@tp1.ruhr-uni-bochum.de \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox