Re: eepro100.c - Add option to disable power saving in 2.4.7-ac7

Andrey Savochkin
2001-08-06T16:15:08Z

Hi,

Making it an option looks like a reasonable idea.
However, could you mind the indentation style of the driver, please?

On Mon, Aug 06, 2001 at 05:48:04PM +0200, Martin Knoblauch wrote:
> after realizing that my first attempt for this patch was to
> enthusiastic, I have no a somewhat stripped down version. Compiles
> against 2.4.7-ac7.
>
> The patch adds the option "power_save" to eepro100. If "1" (default),
> power save handling is done as normal. If "0", no power saving is done.
> This is to workaround some flaky eepro100 adapters that do not survive
> D0->D2-D0 transitions.
[snip]
> @@ -1833,7 +1842,8 @@
> if (speedo_debug > 0)
> printk(KERN_DEBUG "%s: %d multicast blocks dropped.\n", dev->name, i);
>
> - pci_set_power_state(sp->pdev, 2);
> + if (power_save)
> + pci_set_power_state(sp->pdev, 2);
>
> MOD_DEC_USE_COUNT;
>

Best regards
Andrey