Re: Problem with usb-storage using HP 8200 external CD-ROM burner

[Brent Baccala <baccala@freesoft.org>]

Jens Axboe wrote:
> 
> On Mon, Aug 06 2001, Matthew Dharm wrote:
> > >       774         spin_lock_irqsave(&io_request_lock, flags);
> > >       775         rtn = SCpnt->host->hostt->eh_abort_handler(SCpnt);
> > >       776         spin_unlock_irqrestore(&io_request_lock, flags);
> > >
> > > seems like a real shotgun approach.  Get rid of the spinlock stuff, and
> > > make sure that the abort handlers lock io_request_lock themselves if
> > > they need it.  Of course, this would require changes to all the scsi
> > > drivers.
> >
> > Hrm... perhaps I could just unlock that spinlock and then re-lock it before
> > returning.  Anyone have a clue if this would work?
> 
> That would work -- stuff like the above is already scheduled for removal
> for 2.5. Locking will be moved from the mid layer to the drivers
> themselves.

If that's the case (the locking will be moved in 2.5), then I'd suggest
using Matthew's idea of unlocking, then re-locking the spinlock, as a
temporary measure.

-- 
                                        -bwb

                                        Brent Baccala
                                        baccala@freesoft.org

==============================================================================
       For news from freesoft.org, subscribe to announce@freesoft.org:
   
mailto:announce-request@freesoft.org?subject=subscribe&body=subscribe
==============================================================================