From: Tim Hockin <thockin@sun.com>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
torvalds@transmeta.com, alan@redhat.com
Subject: [PATCH] small SCSI use count fix
Date: Mon, 13 Aug 2001 21:43:18 -0700 [thread overview]
Message-ID: <3B78AC66.3621AD86@sun.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 368 bytes --]
Attached is a small fix to increment the use count in scsi_register_host()
before we start working with it - prevent false decrementing. (from one of
the crew here ;)
Please let me know if there is any reason this shouldn't go mainline in the
next 2.4.x.
thanks
Tim
--
Tim Hockin
Systems Software Engineer
Sun Microsystems, Cobalt Server Appliances
thockin@sun.com
[-- Attachment #2: scsi_use_count.diff --]
[-- Type: text/plain, Size: 712 bytes --]
diff -ruN dist+patches-2.4.8/drivers/scsi/scsi.c cobalt-2.4.8/drivers/scsi/scsi.c
--- dist+patches-2.4.8/drivers/scsi/scsi.c Thu Jul 19 21:07:04 2001
+++ cobalt-2.4.8/drivers/scsi/scsi.c Mon Aug 13 16:42:24 2001
@@ -1835,6 +1828,8 @@
pcount = next_scsi_host;
+ MOD_INC_USE_COUNT;
+
/* The detect routine must carefully spinunlock/spinlock if
it enables interrupts, since all interrupt handlers do
spinlock as well.
@@ -1964,8 +1965,6 @@
(scsi_init_memory_start - scsi_memory_lower_value) / 1024,
(scsi_memory_upper_value - scsi_init_memory_start) / 1024);
#endif
-
- MOD_INC_USE_COUNT;
if (out_of_space) {
scsi_unregister_host(tpnt); /* easiest way to clean up?? */
reply other threads:[~2001-08-14 4:39 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3B78AC66.3621AD86@sun.com \
--to=thockin@sun.com \
--cc=alan@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox