public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] small SCSI use count fix
@ 2001-08-14  4:43 Tim Hockin
  0 siblings, 0 replies; only message in thread
From: Tim Hockin @ 2001-08-14  4:43 UTC (permalink / raw)
  To: Linux Kernel Mailing List, torvalds, alan

[-- Attachment #1: Type: text/plain, Size: 368 bytes --]

Attached is a small fix to increment the use count in scsi_register_host()
before we start working with it - prevent false decrementing.  (from one of
the crew here ;)

Please let me know if there is any reason this shouldn't go mainline in the
next 2.4.x.

thanks
Tim
-- 
Tim Hockin
Systems Software Engineer
Sun Microsystems, Cobalt Server Appliances
thockin@sun.com

[-- Attachment #2: scsi_use_count.diff --]
[-- Type: text/plain, Size: 712 bytes --]

diff -ruN dist+patches-2.4.8/drivers/scsi/scsi.c cobalt-2.4.8/drivers/scsi/scsi.c
--- dist+patches-2.4.8/drivers/scsi/scsi.c	Thu Jul 19 21:07:04 2001
+++ cobalt-2.4.8/drivers/scsi/scsi.c	Mon Aug 13 16:42:24 2001
@@ -1835,6 +1828,8 @@
 
 	pcount = next_scsi_host;
 
+	MOD_INC_USE_COUNT;
+
 	/* The detect routine must carefully spinunlock/spinlock if 
 	   it enables interrupts, since all interrupt handlers do 
 	   spinlock as well.
@@ -1964,8 +1965,6 @@
 	       (scsi_init_memory_start - scsi_memory_lower_value) / 1024,
 	       (scsi_memory_upper_value - scsi_init_memory_start) / 1024);
 #endif
-
-	MOD_INC_USE_COUNT;
 
 	if (out_of_space) {
 		scsi_unregister_host(tpnt);	/* easiest way to clean up?? */

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2001-08-14  4:39 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2001-08-14  4:43 [PATCH] small SCSI use count fix Tim Hockin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox