public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Tim Hockin <thockin@sun.com>
To: "David S. Miller" <davem@redhat.com>
Cc: andrea@suse.de, linux-kernel@vger.kernel.org
Subject: [PATCH] agreed upon poll change
Date: Tue, 14 Aug 2001 17:34:22 -0700	[thread overview]
Message-ID: <3B79C38E.1301044E@sun.com> (raw)
In-Reply-To: <20010814.163804.66057702.davem@redhat.com> <3B79BA07.B57634FD@sun.com> <20010815021110.F4304@athlon.random> <20010814.171609.75760869.davem@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 621 bytes --]

"David S. Miller" wrote:

> Right, and our equivalent is "NR_OPEN".
> 
> Ok, I think I see what you and Tim are trying to say.
> I'm thinking in a select() minded way which is why I didn't
> understand :-)

Whew! :)

> Yeah, the check can be removed, but anyone who cares about
> performance won't pass in huge arrays of -1 entries if only
> the low few pollfd entries are actually useful.

of course...patch attached, for anyone who cares - do we need to send it to
anyone else, or are you going to channel it in, Dave?

-- 
Tim Hockin
Systems Software Engineer
Sun Microsystems, Cobalt Server Appliances
thockin@sun.com

[-- Attachment #2: poll-paranoid.diff --]
[-- Type: text/plain, Size: 528 bytes --]

Index: fs/select.c
===================================================================
RCS file: /home/cvs/linux-2.4/fs/select.c,v
retrieving revision 1.5
diff -u -r1.5 select.c
--- fs/select.c	2001/07/09 23:10:25	1.5
+++ fs/select.c	2001/08/15 00:28:13
@@ -419,9 +419,6 @@
 	if (nfds > NR_OPEN)
 		return -EINVAL;
 
-	if (nfds > current->files->max_fds)
-		nfds = current->files->max_fds;
-
 	if (timeout) {
 		/* Careful about overflow in the intermediate values */
 		if ((unsigned long) timeout < MAX_SCHEDULE_TIMEOUT / HZ)

  parent reply	other threads:[~2001-08-15  0:31 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <3B79B381.58266C13@sun.com>
     [not found] ` <20010814.162710.131914269.davem@redhat.com>
     [not found]   ` <3B79B5F3.C816CBED@sun.com>
     [not found]     ` <20010814.163804.66057702.davem@redhat.com>
2001-08-14 23:53       ` RFC: poll change Tim Hockin
2001-08-14 23:53         ` David S. Miller
2001-08-15  0:08           ` Andrea Arcangeli
2001-08-15  0:09           ` Tim Hockin
2001-08-15  0:06             ` David S. Miller
2001-08-15  0:11         ` Andrea Arcangeli
2001-08-15  0:16           ` David S. Miller
2001-08-15  0:30             ` Andrea Arcangeli
2001-08-15  0:34             ` Tim Hockin [this message]
2001-08-15  0:32               ` [PATCH] agreed upon " David S. Miller
2001-08-15 14:13             ` RFC: " Andrea Arcangeli
2001-08-15 14:24               ` David S. Miller
2001-08-15 14:32                 ` Andrea Arcangeli
2001-08-15 16:30                   ` Hugh Dickins
2001-08-15 16:40                     ` Andrea Arcangeli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3B79C38E.1301044E@sun.com \
    --to=thockin@sun.com \
    --cc=andrea@suse.de \
    --cc=davem@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox