Re: 2.4.9 does not compile [PATCH]

Roman Zippel
2001-08-17T03:39:31Z

Hi,

"David S. Miller" wrote:

> The cast in the new version is not dumb, it's smart.

Yes, it's the smart version of "min((type)a, (type)b)"...

> It's the programmer saying (to both the reader of the
> code and the compiler) "I want this comparison to use
> type X". Period.

Why? Why would anyone want this? Do you need this for any other ordinary
compare? (For which the compiler will also generate "dumb" warnings.)

> There is no ambiguity, there are no multiple-evaluation
> issues, and no dumb warnings from the compiler.

I'm all for fixing the multiple-evaluation, but I don't see why this
warning should be dumb. If you don't like it, use "-Wno-sign-compare".

bye, Roman