Re: Linux 2.4.8-ac10

Andrzej Krzysztofowicz
2001-08-24T17:14:52Z

>
> > Linux 2.4.8-ac10
> >
> > From: Alan Cox (laughing@shared-source.org)
> > o Put config hooks in to make qlogicfc firmware (me)
> > optionally loadable for weird hardware
> > | Needs a suitable firmware file adding ..
>
> shouldn't the question about the FW only be asked if the FC driver is
> actually requested? I have not requested the driver, but get asked (make
> oldconfig) about the FW.

Somebodyd did a typo:

if [ "%CONFIG_SCSI_QLOGIC_FC" != "n" ]; then
^^^
Also indentation of question texts should step by 2, not 3.

BTW, wouldn't it better to use deb_mbool here ?
Patch for all three fixes follows.

Andrzej
*******************************************
--- drivers/scsi/Config.in.old Fri Aug 24 19:03:51 2001
+++ drivers/scsi/Config.in Fri Aug 24 19:08:05 2001
@@ -153,9 +153,7 @@
if [ "$CONFIG_PCI" = "y" ]; then
dep_tristate 'Qlogic ISP SCSI support' CONFIG_SCSI_QLOGIC_ISP $CONFIG_SCSI
dep_tristate 'Qlogic ISP FC SCSI support' CONFIG_SCSI_QLOGIC_FC $CONFIG_SCSI
- if [ "%CONFIG_SCSI_QLOGIC_FC" != "n" ]; then
- bool ' Include loadable firmware in driver' CONFIG_SCSI_QLOGIC_FC_FIRMWARE
- fi
+ dep_mbool ' Include loadable firmware in driver' CONFIG_SCSI_QLOGIC_FC_FIRMWARE $CONFIG_SCSI_QLOGIC_FC
dep_tristate 'Qlogic QLA 1280 SCSI support' CONFIG_SCSI_QLOGIC_1280 $CONFIG_SCSI
fi
if [ "$CONFIG_X86" = "y" ]; then

--
=======================================================================
Andrzej M. Krzysztofowicz ankry@mif.pg.gda.pl
phone (48)(58) 347 14 61
Faculty of Applied Phys. & Math., Technical University of Gdansk