From: Olivier Molteni <olivier@molteni.net>
To: Stephan von Krawczynski <skraw@ithnet.com>
Cc: Erik DeBill <erik@www.creditminders.com>,
linux-kernel@vger.kernel.org, trond.myklebust@fys.uio.no
Subject: Re: nfs client oops, all 2.4 kernels
Date: Mon, 10 Sep 2001 21:52:10 +0200 [thread overview]
Message-ID: <3B9D19EA.7F3AE823@molteni.net> (raw)
In-Reply-To: <20010910100202.A14106@www.creditminders.com> <20010910173420.11d2fa71.skraw@ithnet.com>
Stephan von Krawczynski wrote:
> On Mon, 10 Sep 2001 10:02:02 -0500 Erik DeBill <erik@www.creditminders.com>
> wrote:
>
> > I've been running into a repeatable oops in the NFS client code,
> > apparently related to file locking.
>
>
> in linux/fs/locks.c I would say it fails either because thisfl_p is NULL or
> *thisfl_p is NULL. Try securing it via:
>
> static void locks_delete_lock(struct file_lock **thisfl_p, unsigned int wait)
> {
> struct file_lock *fl;
>
> if (thisfl_p == NULL || *thisfl_p == NULL)
> return;
>
> fl = *thisfl_p;
>
> *thisfl_p = fl->fl_next;
> fl->fl_next = NULL;
>
> ...
> }
>
> This is for sure not the cure, but may help your setup.
Hi, see my post and related answers [ Oops NFS Locking in 2.4.x] I have the same
Problem.
Returning on *thisfl_p == NULL don't fix the trouble... Kernel no more Oops, but
process stay in wait state on IO (D).
See the answers from Trond Myklebust, I think he is right...
Regards,
Olivier.
next prev parent reply other threads:[~2001-09-10 19:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <"from olivier"@molteni.net>
2001-09-10 15:02 ` nfs client oops, all 2.4 kernels Erik DeBill
2001-09-10 15:34 ` Stephan von Krawczynski
2001-09-10 19:52 ` Olivier Molteni [this message]
2001-09-10 20:24 ` edebill
2001-09-11 8:45 ` Trond Myklebust
2001-09-11 13:15 ` Trond Myklebust
2001-09-11 17:26 ` Erik DeBill
2001-09-12 1:52 ` Olivier Molteni
2001-09-13 1:05 ` Olivier Molteni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3B9D19EA.7F3AE823@molteni.net \
--to=olivier@molteni.net \
--cc=erik@www.creditminders.com \
--cc=linux-kernel@vger.kernel.org \
--cc=skraw@ithnet.com \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox