[PATCH] bzImage target for PPC

[PATCH] bzImage target for PPC

[Rusty Russell]

All the instructions (including the message after "make oldconfig")
talk about "make bzImage".  So I suppose it's best to give in to this
rampant Intelism 8)

--- working-pmac-module/arch/ppc/Makefile.~1~	Sat Aug 18 16:38:13 2001
+++ working-pmac-module/arch/ppc/Makefile	Mon Sep 17 14:08:09 2001
@@ -87,6 +87,9 @@
 
 BOOT_TARGETS = zImage zImage.initrd znetboot znetboot.initrd
 
+# All the instructions talk about "make bzImage".
+bzImage: zImage
+
 $(BOOT_TARGETS): $(CHECKS) vmlinux
 	@$(MAKEBOOT) $@
 
Rusty.
--
Premature optmztion is rt of all evl. --DK

Re: [PATCH] bzImage target for PPC

[Tom Rini]

On Mon, Sep 17, 2001 at 02:11:34PM +1000, Rusty Russell wrote:

> All the instructions (including the message after "make oldconfig")
> talk about "make bzImage".  So I suppose it's best to give in to this
> rampant Intelism 8)

What about 'bzlilo' and 'zlilo' ? Those are mentioned too.  Linus, please
don't apply this.  Hopefully Paul will say that too. :)

> --- working-pmac-module/arch/ppc/Makefile.~1~	Sat Aug 18 16:38:13 2001
> +++ working-pmac-module/arch/ppc/Makefile	Mon Sep 17 14:08:09 2001
> @@ -87,6 +87,9 @@
>  
>  BOOT_TARGETS = zImage zImage.initrd znetboot znetboot.initrd
>  
> +# All the instructions talk about "make bzImage".
> +bzImage: zImage
> +
>  $(BOOT_TARGETS): $(CHECKS) vmlinux
>  	@$(MAKEBOOT) $@

-- 
Tom Rini (TR1265)
http://gate.crashing.org/~trini/

Re: [PATCH] bzImage target for PPC

[H. Peter Anvin]

Followup to:  <20010916212538.F14279@cpe-24-221-152-185.az.sprintbbd.net>
By author:    Tom Rini <trini@kernel.crashing.org>
In newsgroup: linux.dev.kernel
> 
> What about 'bzlilo' and 'zlilo' ? Those are mentioned too.  Linus, please
> don't apply this.  Hopefully Paul will say that too. :)
> 

They're mentioned, and generally wrong -- the proper way to install a
kernel is "make install", since that one can be customized for the
appropriate system using /sbin/installkernel.

	-hpa
-- 
<hpa@transmeta.com> at work, <hpa@zytor.com> in private!
"Unix gives you enough rope to shoot yourself in the foot."
http://www.zytor.com/~hpa/puzzle.txt	<amsp@zytor.com>

Re: [PATCH] bzImage target for PPC

[Rusty Russell]

In message <20010916212538.F14279@cpe-24-221-152-185.az.sprintbbd.net> you writ
e:
> On Mon, Sep 17, 2001 at 02:11:34PM +1000, Rusty Russell wrote:
> 
> > All the instructions (including the message after "make oldconfig")
> > talk about "make bzImage".  So I suppose it's best to give in to this
> > rampant Intelism 8)
> 
> What about 'bzlilo' and 'zlilo' ? Those are mentioned too.  Linus, please
> don't apply this.  Hopefully Paul will say that too. :)

Actually, Paul suggested it.  As for bzlilo, that's even a problem on
non-lilo Intel (and should be subsumed by make install).  Of course,
make install should be moved to the top level Makefile, but that's
another battle.

Cheers,
Rusty.
--
Premature optmztion is rt of all evl. --DK

Re: [PATCH] bzImage target for PPC

[Tom Rini]

On Mon, Sep 17, 2001 at 08:07:09PM +1000, Rusty Russell wrote:
> In message <20010916212538.F14279@cpe-24-221-152-185.az.sprintbbd.net> you writ
> e:
> > On Mon, Sep 17, 2001 at 02:11:34PM +1000, Rusty Russell wrote:
> > 
> > > All the instructions (including the message after "make oldconfig")
> > > talk about "make bzImage".  So I suppose it's best to give in to this
> > > rampant Intelism 8)
> > 
> > What about 'bzlilo' and 'zlilo' ? Those are mentioned too.  Linus, please
> > don't apply this.  Hopefully Paul will say that too. :)
> 
> Actually, Paul suggested it.  As for bzlilo, that's even a problem on
> non-lilo Intel (and should be subsumed by make install).  Of course,
> make install should be moved to the top level Makefile, but that's
> another battle.

Bah.  I thought when that text got changed around a bit ages ago (didn't it
used to say something just 'zImage') there was a bit of a thread/flame and
it was just left as an intel-ism, and hopefully users would still do the
'right' thing.  Anyhow, the original patch just makes bzImage not fail as
an unknown target, but not actually do anything.  The 'correct' way I
_think_ would be:
arch/ppc/Makefile:
bzImage: $(CHECKS) vmlinux
	@$(MAKEBOOT) zImage

Or print out a msg saying to use 'zImage'. :)

-- 
Tom Rini (TR1265)
http://gate.crashing.org/~trini/

Re: [PATCH] bzImage target for PPC

[Allan Sandfeld]

On Monday 17 September 2001 12:07, Rusty Russell wrote:

> Actually, Paul suggested it.  As for bzlilo, that's even a problem on
> non-lilo Intel (and should be subsumed by make install).  Of course,
> make install should be moved to the top level Makefile, but that's
> another battle.
Welll.... Shouldnt we fight it then?
What is holding us back from deciding on a limited number of supported and 
implemented make targets and making these fast(e.g. moving install to top 
level)? This would then become a part of kbuild2.5

"Let's party like it's 2.4.99"

>
> Cheers,
> Rusty.

Cheers!

Re: [PATCH] bzImage target for PPC

[Tom Rini]

On Mon, Sep 17, 2001 at 06:32:25PM +0200, Allan Sandfeld wrote:

> What is holding us back from deciding on a limited number of supported and 
> implemented make targets and making these fast(e.g. moving install to top 
> level)? This would then become a part of kbuild2.5

Eh?  What kbuild2.5 does, last time I looked at it, is let the user pick from
the list of targets for that arch, for 'installable'.  This looks great
from the PPC side, which has ~6 targets for this right now.  No need to
limit to some 'generic' names or limit the number.  For 2.4, I don't think
we should bother to do anything, except _maybe_ change the text after
oldconfig/whatnot to say 'zImage or bzImage and then install'  Or nuke
it all together.

-- 
Tom Rini (TR1265)
http://gate.crashing.org/~trini/

Re: [PATCH] bzImage target for PPC

[Tom Gall]

Tom Rini wrote:
> 
> On Mon, Sep 17, 2001 at 02:11:34PM +1000, Rusty Russell wrote:
> 
> > All the instructions (including the message after "make oldconfig")
> > talk about "make bzImage".  So I suppose it's best to give in to this
> > rampant Intelism 8)
> 
> What about 'bzlilo' and 'zlilo' ? Those are mentioned too.  Linus, please
> don't apply this.  Hopefully Paul will say that too. :)

I'm with Tom on this. Don't apply this one. Additionally in the ppc64 camp we
like our ppc brothern have been sticking with zImage. It seems (least to me)
that it's reasonably documented in ppc and ppc64 circles. Perhaps tho it would
be appropriate to add a short little blurb in the  README for the various
architectures.

> Tom Rini (TR1265)
> http://gate.crashing.org/~trini/

Regards,

Tom

-- 
Tom Gall - PPC64 Code Monkey     "Where's the ka-boom? There was
Linux Technology Center           supposed to be an earth
(w) tom_gall@vnet.ibm.com         shattering ka-boom!"
(w) 507-253-4558                 -- Marvin Martian
(h) tgall@rochcivictheatre.org
http://www.ibm.com/linux/ltc/projects/ppc

Re: [PATCH] bzImage target for PPC

[Keith Owens]

On Mon, 17 Sep 2001 15:01:40 +0000, 
Tom Gall <tom_gall@vnet.ibm.com> wrote:
>Tom Rini wrote:
>I'm with Tom on this. Don't apply this one. Additionally in the ppc64 camp we
>like our ppc brothern have been sticking with zImage. It seems (least to me)
>that it's reasonably documented in ppc and ppc64 circles. Perhaps tho it would
>be appropriate to add a short little blurb in the  README for the various
>architectures.

Probably not worth changing.  In 2.5 the type of kernel to build is an
architecture dependent config option.  Users just make installable to
build and make install to install, kbuild 2.5 takes care of everything
else.