From: "Randy.Dunlap" <rddunlap@osdlab.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Linus <torvalds@transmeta.com>,
lkml <linux-kernel@vger.kernel.org>,
sfr@canb.auug.org.au, crutcher+kernel@datastacks.com
Subject: Re: [PATCH] fix register_sysrq() in 2.4.9++
Date: Thu, 20 Sep 2001 10:48:38 -0700 [thread overview]
Message-ID: <3BAA2BF6.467CEB10@osdlab.org> (raw)
In-Reply-To: <E15k7pZ-0005i0-00@the-village.bc.nu>
Alan Cox wrote:
>
> u> +
> > +static inline int register_sysrq_key(int key, struct sysrq_key_op *op_p)
> > +{
> > + return -1;
> > +}
>
> make it report ok as other non compiled in stuff does - then you can avoid
> masses of ifdefs
Yeah, I considered that, and it doesn't matter to me whether it
reports 0 or -1, but it's the data pointer that (mostly) requires
the #ifdefs, unless the data is always present or a dummy data pointer
is used.... ?
~Randy
next prev parent reply other threads:[~2001-09-20 17:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-09-20 15:51 [PATCH] fix register_sysrq() in 2.4.9++ Randy.Dunlap
2001-09-20 17:41 ` Alan Cox
2001-09-20 17:48 ` Randy.Dunlap [this message]
2001-09-20 17:59 ` Alan Cox
2001-09-20 18:57 ` [PATCH:v2] " Randy.Dunlap
2001-09-21 22:22 ` Crutcher Dunnavant
2001-09-21 22:36 ` [PATCH] Magic SysRq alternate fix register functions Crutcher Dunnavant
2001-09-24 16:32 ` Randy.Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3BAA2BF6.467CEB10@osdlab.org \
--to=rddunlap@osdlab.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=crutcher+kernel@datastacks.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox