public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Randy.Dunlap" <rddunlap@osdlab.org>
To: Alex Cruise <acruise@infowave.com>
Cc: "'linux-kernel@vger.kernel.org'" <linux-kernel@vger.kernel.org>,
	jcb@jcb.yi.org, Alan <alan@lxorguk.ukuu.org.uk>,
	sfr@canb.auug.org.au
Subject: Re: apm suspend broken in 2.4.10
Date: Thu, 27 Sep 2001 13:36:25 -0700	[thread overview]
Message-ID: <3BB38DC9.39A0A9F6@osdlab.org> (raw)
In-Reply-To: <6B90F0170040D41192B100508BD68CA1015A81A7@earth.infowave.com>

[-- Attachment #1: Type: text/plain, Size: 639 bytes --]

Alex Cruise wrote:
> 
> Mine displays a similar failure, except my strace shows:
> 
>   ioctl(3, APM_IOC_SUSPEND, 0 ) = -1 EAGAIN (Resource temporarily
> unavailable)
> 
> I also noticed (as reported by a previous poster) that whether you pass
> "apm=on" or "apm=off" to the kernel, apm gets disabled.  When you don't
> specify a setting, it's enabled.  I had a look at the arch/i386/kernel/apm.c
> in 2.4.10 though, and it seemed to make sense.

Verified here.
APM doesn't install if apm=on or apm=off is used in 2.4.10.

Here's a small patch for it.  With this patch, apm thread,
/proc/apm, misc apm_bios device etc. are created.

~Randy

[-- Attachment #2: apmonoff.patch --]
[-- Type: text/plain, Size: 662 bytes --]

--- linux/arch/i386/kernel/apm.c.org	Mon Sep 17 22:52:35 2001
+++ linux/arch/i386/kernel/apm.c	Thu Sep 27 13:15:33 2001
@@ -1672,7 +1672,7 @@
 		apm_info.realmode_power_off = 1;
 	/* User can override, but default is to trust DMI */
 	if (apm_disabled != -1)
-		apm_info.disabled = 1;
+		apm_info.disabled = apm_disabled;
 
 	/*
 	 * Fix for the Compaq Contura 3/25c which reports BIOS version 0.1
@@ -1699,8 +1699,7 @@
 	}
 
 	if (apm_info.disabled) {
-		if(apm_disabled == 1)
-			printk(KERN_NOTICE "apm: disabled on user request.\n");
+		printk(KERN_NOTICE "apm: disabled on user request.\n");
 		return -ENODEV;
 	}
 	if ((smp_num_cpus > 1) && !power_off) {

  reply	other threads:[~2001-09-27 20:38 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-09-27  0:29 apm suspend broken in 2.4.10 Alex Cruise
2001-09-27 20:36 ` Randy.Dunlap [this message]
  -- strict thread matches above, loose matches on Subject: below --
2001-09-28 22:30 Alex Cruise
2001-09-28 22:31 ` Randy.Dunlap
     [not found] <6B90F0170040D41192B100508BD68CA1015A81B2@earth.infowave.co m>
2001-09-28  3:31 ` Lewin A.R.W. Edwards
2001-09-28  3:03 Alex Cruise
2001-09-28  1:50 Alex Cruise
2001-09-28 22:05 ` Randy.Dunlap
2001-09-27 23:56 Alex Cruise
2001-09-28  0:10 ` Randy.Dunlap
2001-09-28  0:52 ` Alan Cox
2001-09-28  9:09   ` jc
2001-09-28 10:05     ` Keith Owens
2001-09-27 21:07 Alex Cruise
2001-09-27 21:03 Alex Cruise
2001-09-27 22:17 ` Randy.Dunlap
2001-09-28  9:12   ` jc
2001-09-25 22:00 jc
2001-09-26  8:44 ` Matthias Andree

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3BB38DC9.39A0A9F6@osdlab.org \
    --to=rddunlap@osdlab.org \
    --cc=acruise@infowave.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=jcb@jcb.yi.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox