Re: PnP BIOS + 2.4.9-ac16 = no boot

Thomas Hood
2001-09-28T13:48:12Z

[-- Attachment #1: Type: text/plain, Size: 1777 bytes --]

Stelian:

In -ac15 the PnP BIOS driver was changed so that the proc interface
got the "current" and "boot" configurations the right way 'round.
As a side effect the change made the initialization routine
build its device list from the "current" configuration as opposed
to the "boot" configuration (... which seemed like the right thing
to do at the time, heh heh ... hmmmmm).

You wrote:
> With the patch a third line is printed before the oops:
> PnP: PNP BIOS 13 devices detected (or something like that).

The patch I sent you reverted the build_devlist function to looking
at the "boot" configuration. Your output shows that the devlist
got built this time, which is good. However you still got an oops,
which is bad. My guess is that the oops now occurs in pnp_proc_init().
I attach a revised patch which cuts out proc support. Hopefully
this will allow your kernel to boot. This is just a hack; I'll
submit a proper fix to Alan later.

Alan (if you're listening): The patches I have already sent you are
still okay to go since they don't affect this issue. What I need
to do is submit a patch that, for Sony laptops, (1) causes pnpbios
to build its devlist from the "boot" configuration, and (2) omits
the "current" configuration from /proc/bus/pnp. I'll work on this
tonight.

Stelian: Your report made me go back and look at something Alan
told me earlier about Vaio laptops. At the time I didn't fully
understand what he meant when he said:
> If you query the current device status on a Vaio and some other boxes
> using the 32bit API your computer dies horribly shortly afterwards.
I didn't realize that he meant the "current" configuration as
opposed to the "boot" configuration. Stupid of me.

--
Thomas
P.S. The attached patch is only a temporary hack!

[-- Attachment #2: thood-pnpbiosvaio-patch-20010928-2 --]
[-- Type: text/plain, Size: 781 bytes --]

--- pnp_bios.c_ORIG Thu Sep 27 15:21:46 2001
+++ pnp_bios.c_vaiofix Fri Sep 28 09:38:16 2001
@@ -614,11 +614,11 @@
pnp_bios_inst_struc = check;
break;
}
pnpbios_build_devlist();
#ifdef CONFIG_PROC_FS
- pnp_proc_init();
+ // pnp_proc_init();
#endif
#ifdef CONFIG_HOTPLUG
init_completion(&unload_sem);
if(kernel_thread(pnp_dock_thread, NULL, CLONE_FS | CLONE_FILES | CLONE_SIGNAL)>0)
unloading = 0;
@@ -845,11 +845,11 @@
for(i=0;i<0xff;i++) {
dev = kmalloc(sizeof (struct pci_dev), GFP_KERNEL);
if (!dev)
break;

- if (pnp_bios_get_dev_node((u8 *)&num, (char )0 , node))
+ if (pnp_bios_get_dev_node((u8 *)&num, (char )1 , node))
continue;

devs++;
pnpbios_rawdata_2_pci_dev(node,dev);
dev->devfn=num;