From: Peter Rival <frival@zk3.dec.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: paulus@samba.org, torvalds@transmeta.com,
linux-kernel@vger.kernel.org, trini@kernel.crashing.org,
benh@kernel.crashing.org
Subject: Re: [PATCH] change name of rep_nop
Date: Fri, 05 Oct 2001 14:06:52 -0400 [thread overview]
Message-ID: <3BBDF6BC.5000300@zk3.dec.com> (raw)
In-Reply-To: <E15pW6U-0006Xx-00@the-village.bc.nu>
Alan Cox wrote:
>>Here is a patch that addresses those three issues. It adds an empty
>>definition of cpu_relax for all architectures except x86 (for x86 it
>>is defined to be rep_nop), and it changes smp_init to use a barrier
>>instead of making wait_init_idle be volatile.
>>
>>
>
> Looks good to me
You also need to move the call to smp_boot_cpus() below the
clear_bit(...) line in smp_init(). Without it, my Wildfire doesn't get
past the while(wait_init_idle) loop - seems all of the CPUs have already
done their work before the mask is set. Besides, it's the right place
for it anyway. I'd generate a patch, but my system is bogged down in a
benchmark for the next couple of hours. If someone says so, I'll
generate the patch after that...
- Pete
next prev parent reply other threads:[~2001-10-05 18:08 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-10-05 10:46 [PATCH] change name of rep_nop Paul Mackerras
2001-10-05 14:37 ` Alan Cox
2001-10-05 18:06 ` Peter Rival [this message]
2001-10-05 23:28 ` Paul Mackerras
2001-10-05 23:54 ` Martin J. Bligh
2001-10-06 1:40 ` Paul Mackerras
2001-10-08 19:27 ` Peter Rival
2001-10-08 22:36 ` David Woodhouse
2001-10-08 22:46 ` David S. Miller
2001-10-08 23:16 ` Alan Cox
2001-10-08 23:24 ` Dave Jones
2001-10-08 23:30 ` David S. Miller
2001-10-08 23:33 ` Alan Cox
2001-10-09 5:01 ` George Greer
2001-10-09 10:33 ` Benjamin Herrenschmidt
2001-10-09 11:30 ` Keith Owens
2001-10-09 12:13 ` Benjamin Herrenschmidt
2001-10-09 12:15 ` Alan Cox
2001-10-08 22:49 ` Alan Cox
2001-10-08 23:06 ` David Woodhouse
2001-10-08 23:08 ` David S. Miller
2001-10-08 23:42 ` David Woodhouse
2001-10-08 23:46 ` David S. Miller
2001-10-08 23:46 ` Linus Torvalds
2001-10-09 0:03 ` David Woodhouse
-- strict thread matches above, loose matches on Subject: below --
2001-10-09 8:51 Etienne Lorrain
2001-10-09 11:30 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3BBDF6BC.5000300@zk3.dec.com \
--to=frival@zk3.dec.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulus@samba.org \
--cc=torvalds@transmeta.com \
--cc=trini@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox