public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@zip.com.au>
To: Luis Montgomery <monty@fismat1.fcfm.buap.mx>
Cc: linux-kernel@vger.kernel.org
Subject: Re: 2.4.11: problem with at1700
Date: Wed, 10 Oct 2001 09:14:49 -0700	[thread overview]
Message-ID: <3BC473F9.EB65B6B2@zip.com.au> (raw)
In-Reply-To: <Pine.GSO.4.21.0110100409260.27961-100000@fismat1.fcfm.buap.mx>

Luis Montgomery wrote:
> 
> I try to compile 2.4.11 and find this error:
> 
> gcc -D__KERNEL__ -I/usr/src/linux-2.4.11/include -Wall -Wstrict-prototypes
> -Wno-trigraphs -O2 -fomit-frame-pointer -fno-strict-aliasing -fno-common
> -pipe -mpreferred-stack-boundary=2 -march=i686 -DMODULE -DMODVERSIONS
> -include /usr/src/linux-2.4.11/include/linux/modversions.h   -c -o
> at1700.o at1700.c
> at1700.c:475: conflicting types for `read_eeprom'
> at1700.c:161: previous declaration of `read_eeprom'
> make[2]: *** [at1700.o] Error 1
> 

That's an easy one:

--- linux-2.4.11/drivers/net/at1700.c	Tue Oct  9 21:31:38 2001
+++ linux-akpm/drivers/net/at1700.c	Wed Oct 10 09:03:41 2001
@@ -158,7 +158,7 @@ struct net_local {
 extern int at1700_probe(struct net_device *dev);
 
 static int at1700_probe1(struct net_device *dev, int ioaddr);
-static int read_eeprom(int ioaddr, int location);
+static int read_eeprom(long ioaddr, int location);
 static int net_open(struct net_device *dev);
 static int	net_send_packet(struct sk_buff *skb, struct net_device *dev);
 static void net_interrupt(int irq, void *dev_id, struct pt_regs *regs);

Incidentally, do you use at1700 much?  Does it work OK?
There's an ancient patch at http://web.gnu.walfield.org/mail-archive/linux-kernel/2000-July/3897.html
which seems fairly significant, but it's rare hardware, and I don't
think there have been any bug reports.


-

      parent reply	other threads:[~2001-10-10 16:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-10-10  9:19 2.4.11: problem with at1700 Luis Montgomery
2001-10-10 16:08 ` Jeff Garzik
2001-10-10 16:14 ` Andrew Morton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3BC473F9.EB65B6B2@zip.com.au \
    --to=akpm@zip.com.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=monty@fismat1.fcfm.buap.mx \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox