From: Jesper Juhl <juhl@eisenstein.dk>
To: Steve Martin <ecprod@bellsouth.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: PROBLEM: IEEE1284 parport code won't build in 2.4.12
Date: Fri, 12 Oct 2001 15:11:26 +0200 [thread overview]
Message-ID: <3BC6EBFE.2050408@eisenstein.dk> (raw)
In-Reply-To: <3BC6E89A.BA8F98B6@bellsouth.net>
Steve Martin wrote:
> This has already been passed on to Tim Waugh, but here's
> a heads-up:
>
> drivers/parport/ieee1284_ops.c -- invokes an undefined
> enum entry from parport.h -- as a result the code
> won't build.
I believe that is the problem that Linus posted this fix for (try it out):
--- linux/drivers/parport/ieee1284_ops.c.origThu Oct 11 09:40:39 2001
+++ linux/drivers/parport/ieee1284_ops.cThu Oct 11 09:40:42 2001
@@ -362,7 +362,7 @@
} else {
DPRINTK (KERN_DEBUG "%s: ECP direction: failed to reverse\n",
port->name);
-port->ieee1284.phase = IEEE1284_PH_DIR_UNKNOWN;
+port->ieee1284.phase = IEEE1284_PH_ECP_DIR_UNKNOWN;
} return retval;
@@ -394,7 +394,7 @@
DPRINTK (KERN_DEBUG
"%s: ECP direction: failed to switch forward\n",
port->name);
-port->ieee1284.phase = IEEE1284_PH_DIR_UNKNOWN;
+port->ieee1284.phase = IEEE1284_PH_ECP_DIR_UNKNOWN;
}
Regards,
Jesper Juhl
prev parent reply other threads:[~2001-10-12 13:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-10-12 12:56 PROBLEM: IEEE1284 parport code won't build in 2.4.12 Steve Martin
2001-10-12 13:11 ` Jesper Juhl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3BC6EBFE.2050408@eisenstein.dk \
--to=juhl@eisenstein.dk \
--cc=ecprod@bellsouth.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox