RE: crc32 cleanups

Matt_Domsch
2001-10-12T22:20:10Z

> I was pondering whether it was ok to unconditionally include the
> lib/crc32.c code, regardless of need. I am leaning towards
> "no," which
> implies Makefile and Config.in rules which must be updated for each
> driver that uses crc32.

OK, I'm taking this approach.

> * if ether_crc is always == ether_crc_be, then create a
> #define instead of patching driver code

Done.

> * no need to inline ether_crc_be, stick it in lib/crc32.c also

Done.

> * using a ref-counting init_crc32 and cleanup_crc32
> (linux/lib/Makefile)
> obj-$(CONFIG_TULIP) += crc32.o
> obj-$(CONFIG_NATSEMI) += crc32.o
> obj-$(CONFIG_DMFE) += crc32.o
> obj-$(CONFIG_ANOTHERDRIVER) += crc32.o

Done. init_crc32() needs to be called from all drivers which call crc32()
or ether_crc_le(). I think I've got them added, but will verify and report
back after the weekend. For the curious, I've got one big patch with crc32,
GPT, efivars, and uuid stuff (separates pretty easily into multiple patches,
but for review now, it's just one).
http://domsch.com/linux/patches/big-crc32-20011012.patch

Thanks,
Matt

--
Matt Domsch
Sr. Software Engineer
Dell Linux Solutions
www.dell.com/linux
#2 Linux Server provider with 17% in the US and 14% Worldwide (IDC)!
#3 Unix provider with 18% in the US (Dataquest)!