Re: crc32 cleanups

Keith Owens
2001-10-13T02:45:13Z

On Fri, 12 Oct 2001 21:36:45 -0500 (CDT),
Jeff Garzik <jgarzik@mandrakesoft.com> wrote:
>On Sat, 13 Oct 2001, Keith Owens wrote:
>> It is better to define CONFIG_CRC32 and have the Config.in files set
>> CONFIG_CRC32 for selected drivers. That avoids the problem of lots of
>> drivers wanting to patch the same Makefile, instead the selection of
>> crc32 is kept with the driver selection.
>
>No, because that doesn't take care of the module case (CONFIG_CRC32=m).

Don't build crc32.o as a module, if it is required at all then make it
built in. Building small service routines as modules is a waste of
space, they take up complete pages when they are loaded.