Re: crc32 cleanups

Jeff Garzik
2001-10-13T01:09:37Z

On Fri, 12 Oct 2001, Horst von Brand wrote:
> Jeff Garzik <jgarzik@mandrakesoft.com> said:
> > We must consider the case where the kernel is built, and then a random
> > 3rd party module comes along that needs crc32 features. An ar library
> > won't cut it, and neither will [the existing crc32 method of] patching
> > linux/lib/crc32.c. That leaves (a) unconditionally building it into the
> > kernel, or (b) Makefile and Config.in rules.
>
> (b) won't work if my kernel has no CRC32 modules, and a random 3rd party
> module needs it. So it looks like firm builtin is the only real option (a).

Sure it will. (b) not only will work, but it is the preferred option.

lib/Makefile will contain the line
obj-$(CONFIG_CRC32) += crc32.o

and arch/$arch/config.in will contain
tristate 'Include crc32 library?' CONFIG_CRC32