Re: crc32 cleanups

Horst von Brand
2001-10-13T01:09:47Z

Matt_Domsch@Dell.com said:
> > That leaves (a) unconditionally building
> > it into the kernel, or (b) Makefile and Config.in rules.

> (a) is simple, but needs a 1KB malloc (or alternately, a 1KB static const
> array - I've taken the approach that the malloc is better)

Better static (less overhead in size and at runtime), initialized at build
time (you could compute it then). In case of _dire_ kernel size problems, it
can be left out anyway. AFAIU, there are now a _lot_ of copies of this
around, so you'll win overall in any case.

> (b) isn't that much harder, but requires drivers to be sure to call
> init_crc32 and cleanup_crc32. If somehow they manage not to do that, Oops.
> I don't want to add a runtime check for the existance of the array in
> crc32().

KISS: Keep It Simple, Stupid. Unless it won't cut it, that is.
--
Horst von Brand vonbrand@sleipnir.valparaiso.cl
Casilla 9G, Vin~a del Mar, Chile +56 32 672616