Re: [PATCH] resubmitting sym53c8xx patches

Tim Hockin
2001-10-18T01:14:16Z

Gérard Roudier wrote:

> About your proposal, it has not been NOKed, but it is not the way I would
> have implemented it. By the way, I already have cleaned up the module
> timer killing ins sym-2.1.15 driver (easily back-portable to sym53c8xx).
> You may look at it (ftp.tux.org) if you are interested in knowing how I

I will look at it.

> The reboot handler stuff is useless in my opinion and OTOH last time I
> looked in the kernel code related to reboot handler stuff it looks to me
> very incomplete. Useless stuff implies additionnal bugs that could have
> been avoided.

We have a bootloader that loads a kernel, then loads another kernel.
Without the reboot handler, we get weird behavior, and SCSI that does not
initialize properly for the second kernel. It may not be useful to
everyone, but it is essential to some.

> I am not opposed to your patch and will not complain if it is applied to
> kernel 2.4. I just haven't time for submitting another patch quickly nor
> have time for following any breakage due to its new interactions with the
> kernel.

I appreciate your concern on this. I'll re-examine the timer stuff, and
if possible, I'd like to get to agreement ASAP, so we can X it off our list
of changes.

Thanks

Tim