public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Romain Dolbeau <dolbeau@irisa.fr>
To: linux-kernel@vger.kernel.org
Subject: Mounting of HFS CD-ROM broke between 2.4.9 and 2.4.10
Date: Thu, 18 Oct 2001 11:25:09 +0200	[thread overview]
Message-ID: <3BCE9FF5.97F7BD8D@irisa.fr> (raw)

Hello,

HFS (Hierarchical File Sytem, from Apple) formatted CD-ROM used
to mount fine until 2.4.9, and file on them were accessible.
They won't mount anymore in 2.4.10 and 2.4.12. Error messages are:

#####
ll_rw_block: device 0b:00: only 2048-char blocks implemented (512)
hfs_fs: unable to read block 0x00000002 from dev 0b:00
hfs_fs: Unable to read superblock
ll_rw_block: device 0b:00: only 2048-char blocks implemented (512)
hfs_fs: unable to read block 0x00000000 from dev 0b:00
hfs_fs: Unable to read block 0.
#####

Between 2.4.9 and 2.4.10, changes were made to this function
including:

#####
--- linux-2.4.9/drivers/block/ll_rw_blk.c       Sat Aug  4 07:37:09 2001
+++ linux-2.4.10/drivers/block/ll_rw_blk.c      Fri Sep 21 06:02:01 2001
[SNIP some other changes]
@@ -990,12 +973,7 @@
        major = MAJOR(bhs[0]->b_dev);
 
        /* Determine correct block size for this device. */
-       correct_size = BLOCK_SIZE;
-       if (blksize_size[major]) {
-               i = blksize_size[major][MINOR(bhs[0]->b_dev)];
-               if (i)
-                       correct_size = i;
-       }
+       correct_size = get_hardsect_size(bhs[0]->b_dev);
 
        /* Verify requested block sizes. */
        for (i = 0; i < nr; i++) {
#####

A check then made on correct_size fails with the above error message.

-- 
DOLBEAU Romain               | Brothers of Metal will always be there     
ENS Cachan / Ker Lann        | Standing together with hands in the air    
Thesard IRISA / CAPS         |           -- Manowar,                      
dolbeaur@club-internet.fr    |                     'Brothers of Metal'

                 reply	other threads:[~2001-10-18  9:24 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3BCE9FF5.97F7BD8D@irisa.fr \
    --to=dolbeau@irisa.fr \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox