From: Jeff Garzik <jgarzik@mandrakesoft.com>
To: Keith Owens <kaos@ocs.com.au>
Cc: linux-kernel@vger.kernel.org, torvalds@transmeta.com
Subject: Re: [patch] 2.4.13 remove unused warnings on module tables
Date: Mon, 29 Oct 2001 01:28:43 -0500 [thread overview]
Message-ID: <3BDCF71B.D89C5E79@mandrakesoft.com> (raw)
In-Reply-To: <4680.1004336672@kao2.melbourne.sgi.com>
Keith Owens wrote:
>
> On Mon, 29 Oct 2001 01:17:15 -0500,
> Jeff Garzik <jgarzik@mandrakesoft.com> wrote:
> >Keith Owens wrote:
> >> @@ -11,6 +11,7 @@
> >> #include <linux/spinlock.h>
> >> #include <linux/list.h>
> >>
> >> +#ifndef CONFIG_KBUILD_2_5
> >> #ifdef __GENKSYMS__
> >> # define _set_ver(sym) sym
> >> # undef MODVERSIONS
> >> @@ -21,6 +22,7 @@
> >> # include <linux/modversions.h>
> >> # endif
> >> #endif /* __GENKSYMS__ */
> >> +#endif /* CONFIG_KBUILD_2_5 */
> >>
> >> #include <asm/atomic.h>
> >>
> >> @@ -257,8 +259,6 @@ static const unsigned long __module_##gt
> >
> >I don't think we need this part of the patch.
>
> It is a small change to module.h that is required for kbuild 2.5 and
> has no effect on 2.4. Saves me having to send another patch later.
If everybody did this Linus would get 1001 unnecessary changes for 1002
patches...
Look, this isn't 2.5. Everyone else has to separate out their 2.5
patches. You're not special, you need to do it too... Let's actually
take another half-second when sending patches to make sure Linus only
gets the changes destined for 2.4. Keep the patch noise down, and help
out not only Linus but everyone else reviewing 2.4 code.
Jeff, keeper of tree purity
--
Jeff Garzik | Only so many songs can be sung
Building 1024 | with two lips, two lungs, and one tongue.
MandrakeSoft | - nomeansno
next prev parent reply other threads:[~2001-10-29 6:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-10-28 9:58 2.4.13 errors and warnings Keith Owens
2001-10-28 18:03 ` Greg KH
2001-10-29 2:12 ` [patch] 2.4.13 remove unused warnings on module tables Keith Owens
2001-10-29 6:17 ` Jeff Garzik
2001-10-29 6:24 ` Keith Owens
2001-10-29 6:28 ` Jeff Garzik [this message]
2001-10-29 11:17 ` 2.4.13 errors and warnings Kai Germaschewski
2001-10-29 23:35 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3BDCF71B.D89C5E79@mandrakesoft.com \
--to=jgarzik@mandrakesoft.com \
--cc=kaos@ocs.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox