From: Manik Raina <manik@cisco.com>
To: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix for warnings for i2o
Date: Tue, 30 Oct 2001 09:55:28 +0530 [thread overview]
Message-ID: <3BDE2BB8.F926AE04@cisco.com> (raw)
In-Reply-To: <Pine.GSO.4.33.0110291733020.28035-100000@cbin2-view1.cisco.com>
The warnings i am try to fix are as follows ....
i2o_block.c: In function `i2ob_install_device':
i2o_block.c:1375: warning: comparison is always zero due to width of bitfield
i2o_block.c:1378: warning: comparison is always zero due to width of bitfield
FYI ...
Manik Raina wrote:
> i2o code compilation gives a warning which is due
> to the fact that queue_buggy (i2o_block.c:1375, 1378)
> is compared to 1 and 2, even though it's 1 bit in size.
>
> queue_buggy is set to 0, 1 and 2 and hence the warnings
> go away when the size is increased.
>
> diffs attached ....
>
> Index: i2o.h
> ===================================================================
> RCS file: /vger/linux/include/linux/i2o.h,v
> retrieving revision 1.17
> diff -u -r1.17 i2o.h
> --- i2o.h 22 Oct 2001 06:46:34 -0000 1.17
> +++ i2o.h 29 Oct 2001 11:34:55 -0000
> @@ -82,7 +82,7 @@
> struct i2o_pci
> {
> int irq;
> - int queue_buggy:1; /* Don't send a lot of messages */
> + int queue_buggy:3; /* Don't send a lot of messages */
> int short_req:1; /* Use small block sizes */
> int dpt:1; /* Don't quiesce */
> #ifdef CONFIG_MTRR
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
prev parent reply other threads:[~2001-10-30 4:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-10-29 12:05 [PATCH] fix for warnings for i2o Manik Raina
2001-10-30 4:25 ` Manik Raina [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3BDE2BB8.F926AE04@cisco.com \
--to=manik@cisco.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox