From: Tim Hockin <thockin@sun.com>
To: Patrick Mochel <mochel@osdl.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
torvalds@transmeta.com, alan@redhat.com, p_gortmaker@yahoo.com
Subject: Re: [PATCH] don't reset alarm interrupt on RTC
Date: Wed, 31 Oct 2001 14:34:57 -0800 [thread overview]
Message-ID: <3BE07C91.6BCAB167@sun.com> (raw)
In-Reply-To: <Pine.LNX.4.33.0110311408330.11035-100000@osdlab.pdx.osdl.net>
Patrick Mochel wrote:
> - tmp &= ~RTC_AIE;
> + //tmp &= ~RTC_AIE;
> tmp &= ~RTC_UIE;
> CMOS_WRITE(tmp, RTC_CONTROL);
> CMOS_READ(RTC_INTR_FLAGS);
> Why would you want to unconditionally enable this interrupt?
We don't unconditionally set it, we just leave it enabled (the code was
uncoditionally UNsetting it). There are ioctl()s to set/unset PIE, AIE,
UIE.
> And how do you set the alarm time?
ioctl(fd, RTC_ALM_SET);
> But, I don't think this should be enabled by default.
if anything, our patch is not correct ENOUGH. none of AIE, PIE, or UIE,
should be molested by rtc_release().
--
Tim Hockin
Systems Software Engineer
Sun Microsystems, Cobalt Server Appliances
thockin@sun.com
prev parent reply other threads:[~2001-10-31 22:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-10-31 22:08 [PATCH] don't reset alarm interrupt on RTC Tim Hockin
2001-10-31 22:13 ` Patrick Mochel
2001-10-31 22:34 ` Tim Hockin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3BE07C91.6BCAB167@sun.com \
--to=thockin@sun.com \
--cc=alan@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mochel@osdl.org \
--cc=p_gortmaker@yahoo.com \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox