problem with kernel 2.4.14 drivers/block/loop.c mm/swap.c

problem with kernel 2.4.14 drivers/block/loop.c mm/swap.c

[Michel Valin]

[-- Attachment #1: Type: text/plain, Size: 636 bytes --]


drivers/block/loop.c used by loopback filesystem code uses function

deactivate_page that was defined in mm/swap.c in kernel 2.4.13

deactivate_page seems to have been suppressed at kernel level 2.4.14
from
mm/swap.c

this results in missing entry point complaints when trying to load
module loop.o
at kernel level 2.4.14

I am not knowledgeable about these modules and am not sure if or how
loop.c and/or swap.c should be fixed

I could not find any other place to report theses findings either.

hoping that you can forward this to the proper person.

-- 
M.Valin
Recherche en Prevision Numerique
Michel.Valin@ec.gc.CA
(514) 421-4753

[-- Attachment #2: Card for Michel Valin --]
[-- Type: text/x-vcard, Size: 226 bytes --]

begin:vcard 
n:Valin;Michel
x-mozilla-html:FALSE
org:R.P.N.;Environnement Canada
adr:;;;;;;
version:2.1
email;internet:michel.valin@ec.gc.ca
title:Analyste Principal / Senior Analyst
x-mozilla-cpt:;0
fn:Michel Valin
end:vcard

Re: problem with kernel 2.4.14 drivers/block/loop.c mm/swap.c

[Adrian Bunk]

On Thu, 8 Nov 2001, Michel Valin wrote:

> drivers/block/loop.c used by loopback filesystem code uses function
>
> deactivate_page that was defined in mm/swap.c in kernel 2.4.13
>
> deactivate_page seems to have been suppressed at kernel level 2.4.14
> from
> mm/swap.c
>...


This is a known bug.

The following patch fixes it:

--- linux-2.4.14-broken/drivers/block/loop.c	Thu Oct 25 13:58:34 2001
+++ linux-2.4.14/drivers/block/loop.c	Mon Nov  5 17:06:08 2001
@@ -207,7 +207,6 @@
 		index++;
 		pos += size;
 		UnlockPage(page);
-		deactivate_page(page);
 		page_cache_release(page);
 	}
 	return 0;
@@ -218,7 +217,6 @@
 	kunmap(page);
 unlock:
 	UnlockPage(page);
-	deactivate_page(page);
 	page_cache_release(page);
 fail:
 	return -1;



cu
Adrian

-- 

Get my GPG key: finger bunk@debian.org | gpg --import

Fingerprint: B29C E71E FE19 6755 5C8A  84D4 99FC EA98 4F12 B400