From: Martin Dalecki <dalecki@evision-ventures.com>
To: Russell King <rmk@arm.linux.org.uk>
Cc: dalecki@evision.ag, Alan Cox <alan@lxorguk.ukuu.org.uk>,
Linus Torvalds <torvalds@transmeta.com>,
linux-kernel@vger.kernel.org
Subject: Re: Merge BUG in 2.4.15-pre4 serial.c
Date: Tue, 13 Nov 2001 18:37:54 +0100 [thread overview]
Message-ID: <3BF15A72.793A1BF2@evision-ventures.com> (raw)
In-Reply-To: <E161TWH-0004G9-00@the-village.bc.nu> <3BF14F14.21D66343@evision-ventures.com> <20011113162111.B21298@flint.arm.linux.org.uk>
Russell King wrote:
>
> On Tue, Nov 13, 2001 at 05:49:24PM +0100, Martin Dalecki wrote:
> > I have found the following code in serial.c aorund line 5565
> >
> > #ifdef __i386__
> > if (i == NR_PORTS) {
> > for (i = 4; i < NR_PORTS; i++)
> > if ((rs_table[i].type == PORT_UNKNOWN) &&
> > (rs_table[i].count == 0))
> > break;
> > }
> > #endif
> > if (i == NR_PORTS) {
> > for (i = 0; i < NR_PORTS; i++)
> > if ((rs_table[i].type == PORT_UNKNOWN) &&
> > (rs_table[i].count == 0))
> > break;
> > }
> >
> > This is supposedly the result of applying some patch twice.
> > Let me guess the first 8 lines of this can be deleted.
>
> Look at it closer, in particular the for() loops.
>
> It's basically there so that on x86, we don't normally use ttyS0-3
> for pcmcia and other similar ports, unless we run out of other ports
> to use.
Well I still think that the 8 lines can be deleted. Once again my famous
notbook is perfectly __i386__ and doesn't contain any devices served by
serial.c
unless I configure IrDA. Pushing the port numbers artificially behind
doesn't make sense for me and makes some setserial unknown tricks
neccessary
for irtty setup.
next prev parent reply other threads:[~2001-11-13 16:45 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-11-06 7:18 Using %cr2 to reference "current" H. Peter Anvin
2001-11-06 8:01 ` Robert Love
2001-11-06 10:55 ` Alan Cox
2001-11-06 17:31 ` Michael Barabanov
2001-11-06 14:14 ` Manfred Spraul
2001-11-06 10:58 ` Alan Cox
2001-11-06 17:04 ` Linus Torvalds
2001-11-06 17:46 ` Alan Cox
2001-11-06 17:59 ` Linus Torvalds
2001-11-06 18:14 ` Alan Cox
2001-11-06 16:55 ` Marcelo Tosatti
2001-11-06 18:14 ` Linus Torvalds
2001-11-06 18:31 ` Alan Cox
2001-11-06 22:38 ` Linus Torvalds
2001-11-07 0:00 ` Martin Dalecki
2001-11-06 23:19 ` Alan Cox
2001-11-07 0:43 ` Martin Dalecki
2001-11-07 0:27 ` Alan Cox
2001-11-07 0:35 ` Jeff Garzik
2001-11-07 14:00 ` Martin Dalecki
2001-11-07 13:38 ` Alan Cox
2001-11-07 14:59 ` Martin Dalecki
2001-11-07 14:17 ` Alan Cox
2001-11-07 14:34 ` Dirk Moerenhout
2001-11-07 14:54 ` Alan Cox
2001-11-07 15:32 ` David Howells
2001-11-07 14:39 ` Intel compiler [Re: Using %cr2 to reference "current"] Sebastian Heidl
2001-11-07 22:05 ` lists
2001-11-07 15:36 ` Using %cr2 to reference "current" Martin Dalecki
2001-11-08 14:08 ` Martin Dalecki
2001-11-13 16:49 ` Merge BUG in 2.4.15-pre4 serial.c Martin Dalecki
2001-11-13 16:21 ` Russell King
2001-11-13 17:37 ` Martin Dalecki [this message]
2001-11-13 16:53 ` Russell King
2001-11-13 18:05 ` Martin Dalecki
2001-11-13 17:11 ` Alan Cox
2001-11-13 18:23 ` Martin Dalecki
2001-11-07 20:04 ` Using %cr2 to reference "current" Andrew Morton
2001-11-11 13:16 ` Martin Dalecki
2001-11-11 13:06 ` Keith Owens
2001-11-12 11:28 ` PATCH 2.4.14 mregparm=3 compilation fixes Martin Dalecki
2001-11-12 16:10 ` Keith Owens
2001-11-12 16:25 ` Christoph Hellwig
2001-11-12 17:56 ` Martin Dalecki
2001-11-12 16:42 ` Linus Torvalds
2001-11-12 18:51 ` Martin Dalecki
2001-11-12 20:05 ` Corsspatch patch-2.4.15-pre2 patch-2.4.15-pre3 Martin Dalecki
2001-11-12 20:13 ` BUG BUG hunt the bugs!!! patch-2.4.15-pre5 Martin Dalecki
2001-11-06 17:02 ` Using %cr2 to reference "current" Linus Torvalds
2001-11-06 17:13 ` Benjamin LaHaise
2001-11-06 17:49 ` Linus Torvalds
2001-11-06 18:19 ` Alan Cox
2001-11-09 21:52 ` Jamie Lokier
2001-11-06 18:42 ` Benjamin LaHaise
2001-11-06 19:09 ` H. Peter Anvin
2001-11-06 19:16 ` Dave Jones
2001-11-06 20:10 ` Ricky Beam
2001-11-06 23:09 ` Alan Cox
2001-11-06 23:15 ` Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3BF15A72.793A1BF2@evision-ventures.com \
--to=dalecki@evision-ventures.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=dalecki@evision.ag \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox