public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@mandrakesoft.com>
To: Andreas Dilger <adilger@turbolabs.com>
Cc: Benjamin LaHaise <bcrl@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] reformat mtrr.c to conform to CodingStyle
Date: Tue, 13 Nov 2001 14:21:48 -0500	[thread overview]
Message-ID: <3BF172CC.8E013C7F@mandrakesoft.com> (raw)
In-Reply-To: <20011112232539.A14409@redhat.com> <20011113121022.L1778@lynx.no>

Andreas Dilger wrote:
> 
> On Nov 12, 2001  23:25 -0500, Benjamin LaHaise wrote:
> > Please incorporate this patch to make mtrr.c conform to the standards set
> > forth in Documentation/CodingStyle which make it much more appealing to
> > the eyes.
> >
> >  /*  Put the processor into a state where MTRRs can be safely set  */
> > -static void set_mtrr_prepare (struct set_mtrr_context *ctxt)
> > +static void
> > +set_mtrr_prepare(struct set_mtrr_context *ctxt)
> >  {
> 
> Is that actually CodingStyle?  Don't see it much in the kernel code...

IMHO CodingStyle is defined in theory by Documentation/CodingStyle, and
in practice by linux/scripts/Lindent, which was changed in 2.4.15-preXX
even, to be more up-to-date.

	Jeff



-- 
Jeff Garzik      | Only so many songs can be sung
Building 1024    | with two lips, two lungs, and one tongue.
MandrakeSoft     |         - nomeansno


  parent reply	other threads:[~2001-11-13 19:22 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-11-13  4:25 [PATCH] reformat mtrr.c to conform to CodingStyle Benjamin LaHaise
2001-11-13 17:04 ` Linus Torvalds
2001-11-13 19:05   ` Chris Wedgwood
2001-11-13 19:11     ` Jeff Garzik
2001-11-14 10:42     ` Helge Hafting
2001-11-14 15:30       ` Jeff Garzik
2001-11-14 16:56         ` Christoph Hellwig
2001-11-13 19:10 ` Andreas Dilger
2001-11-13 19:18   ` Benjamin LaHaise
2001-11-13 19:21   ` Momchil Velikov
2001-11-13 19:21   ` Jeff Garzik [this message]
2001-11-14  7:57   ` David Weinehall
2001-11-14  8:04     ` David S. Miller
2001-11-14  8:15     ` Jeff Garzik
2001-11-20  8:47     ` Mark van Walraven
2001-11-20  9:52       ` David Weinehall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3BF172CC.8E013C7F@mandrakesoft.com \
    --to=jgarzik@mandrakesoft.com \
    --cc=adilger@turbolabs.com \
    --cc=bcrl@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox