Re: [PATCH] Next cut of new devfs core

[Roman Zippel <zippel@linux-m68k.org>]

Richard Gooch wrote:

> If people could try this out and report back, I'd appreciate it.

Do you have any other intentions for us than to just "try this out"? If
not then an URL to the patch would suffice instead of flooding the list
with lots of 80kB patches.
If you want other feedback, I would greatly appreciated it, if you would
make it a bit easier for other developers. Incremental patches would
help to see what actually changed, or even better make them available
through CVS (I think I suggested that before).
Your coding style was already mentioned as well, so I'm not going to
repeat that. Anyway, an important point you should understand is that,
you might be the devfs maintainer, but devfs is not an isolated project.
The common project is Linux, which is maintained by lots of people, to
make such a cooperative development effort possible these people have to
agree on some basic rules. One of these rules is the coding style, Linus
might not care too much about it, but by now you should have noticed
several other developers do.
To maintain a high code quality a constant code review is necessary, a
single person can mistakes, that's normal, but it's important to learn
from mistakes. That also requires that other people are able review the
code, but you aren't making it very easy to review your code. If you're
going to continue with this attitude I can only support Al to split the
code. Sorry, there isn't much room for an ego trip, if you're not able
to deliver high quality code (for whatever reasons of which we got
enough by now).

bye, Roman