From: John Ellson <ellson@lucent.com>
To: linux-kernel@vger.kernel.org
Subject: [PATCH] "make modules_install" breaks with new /bin/cp
Date: Mon, 19 Nov 2001 17:00:22 -0500 [thread overview]
Message-ID: <3BF980F6.6080503@lucent.com> (raw)
linux-2.4.15-pre6, fileutils-4.1.1-1.i386.rpm
With my configuration (details not important), "make modules_install" results in:
mkdir -p /lib/modules/2.4.15-pre6/kernel/drivers/sound/
cp soundcore.o sound.o cs4232.o ad1848.o pss.o ad1848.o mpu401.o cs4232.o uart401.o ad1848.o mpu401.o uart6850.o
v_midi.o btaudio.o /lib/modules/2.4.15-pre6/kernel/drivers/sound/
cp: will not overwrite just-created `/lib/modules/2.4.15-pre6/kernel/drivers/sound/ad1848.o' with `ad1848.o'
cp: will not overwrite just-created `/lib/modules/2.4.15-pre6/kernel/drivers/sound/cs4232.o' with `cs4232.o'
cp: will not overwrite just-created `/lib/modules/2.4.15-pre6/kernel/drivers/sound/ad1848.o' with `ad1848.o'
cp: will not overwrite just-created `/lib/modules/2.4.15-pre6/kernel/drivers/sound/mpu401.o' with `mpu401.o'
make[2]: *** [_modinst__] Error 1
This hasn't been a problem with earlier version of /bin/cp (upto fileutils-4.1-4.i386.rpm in RH7.2),
but /bin/cp from fileutils-4.1.1-1.i386.rpm (in the Rawhide collection) is more pedantic about
multiple copies of the same file.
This patch works around this "feature". It would be better if the Makefiles were changed to only
install modules once, but thats a deeper problem.
--- Rules.make.orig Mon Nov 19 16:49:55 2001
+++ Rules.make Mon Nov 19 16:50:20 2001
@@ -173,7 +173,7 @@
_modinst__: dummy
ifneq "$(strip $(ALL_MOBJS))" ""
mkdir -p $(MODLIB)/kernel/$(MOD_DESTDIR)
-
cp $(ALL_MOBJS) $(MODLIB)/kernel/$(MOD_DESTDIR)$(MOD_TARGET)
+
for i in $(ALL_MOBJS);do cp $$i $(MODLIB)/kernel/$(MOD_DESTDIR)$(MOD_TARGET);done
endif
.PHONY: modules_install
--
John Ellson (ellson@lucent.com) Lucent Technologies, Holmdel, NJ, 07733
next reply other threads:[~2001-11-19 22:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-11-19 22:00 John Ellson [this message]
2001-11-19 22:28 ` [PATCH] "make modules_install" breaks with new /bin/cp Richard Gooch
2001-11-20 3:20 ` John Ellson
-- strict thread matches above, loose matches on Subject: below --
2001-11-20 4:39 =?unknown-8bit?B?RnLpZOlyaWMgTC4gVy4=?= Meunier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3BF980F6.6080503@lucent.com \
--to=ellson@lucent.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox