public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Manfred Spraul <manfred@colorfullife.com>
To: Paul Mackerras <paulus@samba.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re:[RFC][PATCH] flush_icache_user_range
Date: Fri, 23 Nov 2001 00:07:24 +0100	[thread overview]
Message-ID: <3BFD852C.C4CDC39F@colorfullife.com> (raw)

 
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

> The patch below changes access_one_page in kernel/ptrace.c to use a
> new function, flush_icache_user_range, instead of flush_icache_page as
> at present.  The reason for making this change is that
> flush_icache_page is also called in do_no_page and do_swap_page, where
> it does a fundamentally different job.  Decoupling the two makes it
> possible to improve performance, because we can make flush_icache_page
> do the flush only when needed.
> 

Could you also check map_user_kiobuf()?

map_user_kiobuf() calls flush_dcache_page() - if I understand
cachetlb.txt correctly that function is only suitable for dcache/mmap
cache coherency, it's not suitable for anon pages. But map_user_kiobuf()
must support arbitrary pages.

And unmap_kiobuf doesn't contain a single cache flush.

--
	Manfred

                 reply	other threads:[~2001-11-22 23:07 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3BFD852C.C4CDC39F@colorfullife.com \
    --to=manfred@colorfullife.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox