From: "H. Peter Anvin" <hpa@zytor.com>
To: Keith Owens <kaos@ocs.com.au>
Cc: linux-kernel@vger.kernel.org
Subject: Re: 2.4.15-final drivers/net/bonding.c includes user space headers
Date: Sun, 25 Nov 2001 18:09:05 -0800 [thread overview]
Message-ID: <3C01A441.6070702@zytor.com> (raw)
In-Reply-To: <1432.1006740397@ocs3.intra.ocs.com.au>
Keith Owens wrote:
>
> kbuild 2.5 does
> '-nostdinc -I/usr/lib/gcc-lib/... gcc version ../include/'
> so it allows includes from the compiler headers. The problem is:
>
> bonding.c includes limits.h, picked up from gcc, OK.
> limits.h includes syslimits.h from gcc, OK.
> syslimits.h tries to include_next <limits.h> to get the user space
> limits, not OK.
>
> Any kernel code that includes limits.h or syslimits.h is polluted by
> user space headers. net/bonding.c does not even need limits.h.
>
How UTTERLY braindamaged... I guess we could provide a (dummy?)
<limits.h> for the kernel environment. I would definitely like to see
the standard compiler-related headers like <stdint.h> as well...
-hpa
next prev parent reply other threads:[~2001-11-26 2:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-11-23 6:31 2.4.15-final drivers/net/bonding.c includes user space headers Keith Owens
2001-11-25 21:49 ` H. Peter Anvin
2001-11-26 2:06 ` Keith Owens
2001-11-26 2:09 ` H. Peter Anvin [this message]
2001-11-26 2:19 ` Keith Owens
2001-11-26 2:22 ` H. Peter Anvin
2001-11-26 5:02 ` David S. Miller
2001-11-26 17:55 ` Thomas Davis
2001-11-26 18:57 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3C01A441.6070702@zytor.com \
--to=hpa@zytor.com \
--cc=kaos@ocs.com.au \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox