From: "Udo A. Steinberg" <reality@delusion.de>
To: Jens Axboe <axboe@suse.de>
Cc: Linus Torvalds <torvalds@transmeta.com>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH] Re: Stuff that needs fixing in 2.5.1-pre4
Date: Fri, 30 Nov 2001 14:54:47 +0100 [thread overview]
Message-ID: <3C078FA7.8E78488C@delusion.de> (raw)
In-Reply-To: <3C06F3A5.D407607A@delusion.de> <20011130084015.H16796@suse.de>
Jens Axboe wrote:
>
> Make the get_block long argument for block a sector_t. Once you have
> that warning free, send on the fix.
Thanks for the tip. Here's a patch against 2.5.1-pre4 that fixes it.
Regards,
Udo.
diff -urN -X dontdiff linux/fs/fat/file.c linux-vanilla/fs/fat/file.c
--- linux/fs/fat/file.c Fri Nov 30 14:35:16 2001
+++ linux-vanilla/fs/fat/file.c Sun Aug 12 19:56:56 2001
@@ -48,7 +48,7 @@
}
-int fat_get_block(struct inode *inode, sector_t iblock, struct buffer_head *bh_result, int create)
+int fat_get_block(struct inode *inode, long iblock, struct buffer_head *bh_result, int create)
{
struct super_block *sb = inode->i_sb;
unsigned long phys;
diff -urN -X dontdiff linux/fs/minix/itree_common.c linux-vanilla/fs/minix/itree_common.c
--- linux/fs/minix/itree_common.c Fri Nov 30 14:39:37 2001
+++ linux-vanilla/fs/minix/itree_common.c Fri Sep 7 18:45:51 2001
@@ -140,7 +140,7 @@
return -EAGAIN;
}
-static inline int get_block(struct inode * inode, sector_t block,
+static inline int get_block(struct inode * inode, long block,
struct buffer_head *bh_result, int create)
{
int err = -EIO;
diff -urN -X dontdiff linux/include/linux/msdos_fs.h linux-vanilla/include/linux/msdos_fs.h
--- linux/include/linux/msdos_fs.h Fri Nov 30 14:36:45 2001
+++ linux-vanilla/include/linux/msdos_fs.h Fri Oct 12 22:48:42 2001
@@ -273,7 +273,7 @@
extern struct inode_operations fat_file_inode_operations;
extern ssize_t fat_file_read(struct file *filp, char *buf, size_t count,
loff_t *ppos);
-extern int fat_get_block(struct inode *inode, sector_t iblock,
+extern int fat_get_block(struct inode *inode, long iblock,
struct buffer_head *bh_result, int create);
extern ssize_t fat_file_write(struct file *filp, const char *buf, size_t count,
loff_t *ppos);
next prev parent reply other threads:[~2001-11-30 13:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-11-30 2:49 Stuff that needs fixing in 2.5.1-pre4 Udo A. Steinberg
2001-11-30 7:40 ` Jens Axboe
2001-11-30 13:54 ` Udo A. Steinberg [this message]
2001-11-30 14:17 ` [Correct PATCH] " Udo A. Steinberg
2001-11-30 19:35 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3C078FA7.8E78488C@delusion.de \
--to=reality@delusion.de \
--cc=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox