Re: [PATCH] remove BKL from drivers' release functions

Jeff Garzik
2001-11-29T01:42:26Z

"David C. Hansen" wrote:
>
> Russell King wrote:
>
> >The BKL is only held for the duration of the open, not until you close the
> >device.
> >
> I'll need to go back and review the changes to the char and block
> devices. I believe that a big chunk of the drivers that we changed were
> misc drivers, so I might still be in luck.
>
> Does everyone agree that we need to get the BKL out of common areas like
> this? For starters, what about adding a pair of spinlocks for block
> devices and character devices to take the place of the BKL in
> serializing opens? Or, should we make it the driver's responsibility
> completely?

Ideally we should eliminate the BKL completely... but you need to
review tons of code when messing around with it, which makes removal
annoying. Al Viro seems to know this stuff pretty well, and possibly
has plans to remove BKL from various bits of the fs's.

Alan Cox made the comment on IRC that BKL was put into the release
method in 2.4 to synchronize open-close-power management. Don't forget
to take that third into account either, in the cases where such applies.

Jeff

--
Jeff Garzik | Only so many songs can be sung
Building 1024 | with two lips, two lungs, and one tongue.
MandrakeSoft | - nomeansno