Re: Possible bugs

Re: Possible bugs

[Bill Crawford]

> Date: 02 Dec 2001 17:29:52 -0500
> From: MIDN Sean Jones <m053546@usna.edu>
> To: linux-kernel@vger.kernel.org

> I was looking for code to cleanup and found these warnings:
...
> agpgart_be.c:524: warning: `agp_generic_create_gatt_table' defined but
> not used
> agpgart_be.c:652: warning: `agp_generic_free_gatt_table' defined but not
> used
> agpgart_be.c:700: warning: `agp_generic_insert_memory' defined but not
> used
> agpgart_be.c:758: warning: `agp_generic_remove_memory' defined but not
> used
...
> Are these functions supposed to be there or are they leftovers from
> previous modifications.

 They're used in a number of places, but some (most? all?) chipsets do
override the "generic" forms, so depending on which chipset(s) you
select in the config, some of these functions may not get used.

 Putting in an explicit "generic" AGP backend might solve the problem;
the other solution is to put #if guards around those functions.  That
strikes me as a bit messy and fragile as any new chipset might need
them, and we don't want some over-zealous hacker removing them because
they're not used by anything at the moment :o)

 Splitting the different chipsets into separate files and putting the
"generic" forms in their own "library" file is probably an option, but
it's debatable whether that file is big enough to really be worth it.

 You could move the ALi-specific code from agp_lookup_host_bridge to
agp_find_supported_device while you're at it ;o) or I might try to do
that in my copious quantities of free time.

> Thanks,
> 
> Sean Jones

-- 
/* Bill Crawford, Unix Systems Developer, Ebone (formerly GTS Netcom) */
#include <stddiscl>
const char *addresses[] = {
    "bill@syseng.netcom.net.uk", "Bill.Crawford@ebone.com",     // work
    "billc@netcomuk.co.uk", "bill@eb0ne.net"                    // home
};

Possible bugs

[MIDN Sean Jones]

I was looking for code to cleanup and found these warnings:

(from 2.4.17-pre2)

dmi_scan.c:195: warning: `disable_ide_dma' defined but not used
agpgart_be.c:524: warning: `agp_generic_create_gatt_table' defined but
not used
agpgart_be.c:652: warning: `agp_generic_free_gatt_table' defined but not
used
agpgart_be.c:700: warning: `agp_generic_insert_memory' defined but not
used
agpgart_be.c:758: warning: `agp_generic_remove_memory' defined but not
used
parport_pc.c:1784: warning: `parport_ECP_supported' defined but not used

Are these functions supposed to be there or are they leftovers from
previous modifications.

Thanks,

Sean Jones

Re: Possible bugs

[Ken Brownfield]

There was a patch sent a month or so ago that removed disable_ida_dma.
I usually apply cleanups like this, but it's a toss-up whether it's
worth it.  Maybe these functions should be removed from 2.5 until
someone complains.

-- 
Ken.
brownfld@irridia.com

On Sun, Dec 02, 2001 at 05:29:52PM -0500, MIDN Sean Jones wrote:
| I was looking for code to cleanup and found these warnings:
| 
| (from 2.4.17-pre2)
| 
| dmi_scan.c:195: warning: `disable_ide_dma' defined but not used
| agpgart_be.c:524: warning: `agp_generic_create_gatt_table' defined but
| not used
| agpgart_be.c:652: warning: `agp_generic_free_gatt_table' defined but not
| used
| agpgart_be.c:700: warning: `agp_generic_insert_memory' defined but not
| used
| agpgart_be.c:758: warning: `agp_generic_remove_memory' defined but not
| used
| parport_pc.c:1784: warning: `parport_ECP_supported' defined but not used
| 
| Are these functions supposed to be there or are they leftovers from
| previous modifications.
| 
| Thanks,
| 
| Sean Jones
| 
| -
| To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
| the body of a message to majordomo@vger.kernel.org
| More majordomo info at  http://vger.kernel.org/majordomo-info.html
| Please read the FAQ at  http://www.tux.org/lkml/