Re: i810 audio patch

Nathan Bryant
2001-12-05T21:13:06Z

Doug Ledford wrote:

> If that fixes it, then the real fix is to find the bug in
> i810_get_free_Wwrite_space() and i810_update_lvi().

It does fix it.

By the way, I'm confused about something. i810_write appears to overrun
the end of the DMA buffer instead of wrapping around to the beginning
when it does copy_from_user. which makes no sense to me.

so ok, the correct number is 31/32nds, not 3/4ths - not so bad.

> By using the first function to find the available data in the GETOPTR
> ioctl, then using update_lvi(), we *should* be setting the lvi
> fragment to exactly 31 sg segments away from the current index. If
> that's failing, and we are instead setting lvi == civ, then things
> will stop and not work.

yeah, i think that's what's happening